AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ir3: Validate that shared registers are in-bound

Browse Source 
This would've caught some bugs with copy lowering.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/22075>
This commit is contained in:
Connor Abbott
2023-10-31 18:09:24 +01:00
committed by Marge Bot
parent 468f070a91
commit b309418380
1 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/freedreno/ir3/ir3_validate.c
View File

@@ -68,6 +68,15 @@ reg_class_flags(struct ir3_register *reg)
return reg->flags & (IR3_REG_HALF | IR3_REG_SHARED | IR3_REG_PREDICATE);
}
static void
validate_reg(struct ir3_validate_ctx *ctx, struct ir3_register *reg)
{
if ((reg->flags & IR3_REG_SHARED) && reg->num != INVALID_REG) {
validate_assert(ctx, reg->num >= SHARED_REG_START);
validate_assert(ctx, reg->num - SHARED_REG_START < SHARED_REG_SIZE);
}
}
static void
validate_src(struct ir3_validate_ctx *ctx, struct ir3_instruction *instr,
struct ir3_register *reg)
@@ -104,6 +113,8 @@ validate_src(struct ir3_validate_ctx *ctx, struct ir3_instruction *instr,
validate_assert(ctx,
found && "tied register not in the same instruction");
}
validate_reg(ctx, reg);
}
/* phi sources are logically read at the end of the predecessor basic block,
@@ -162,6 +173,8 @@ validate_dst(struct ir3_validate_ctx *ctx, struct ir3_instruction *instr,
if (reg->flags & IR3_REG_RELATIV)
validate_assert(ctx, instr->address);
validate_reg(ctx, reg);
}
#define validate_reg_size(ctx, reg, type) \