AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

intel/blorp: Set needs_(dst|src)_offset for Gen4 cubemaps

Browse Source 
We call convert_to_single_slice so they may end up with a non-trivial
offset that needs to be taken into account.

v2 (idr): Also set needs_src_offset.  Suggested by Jason.

Fixes ES2-CTS.functional.texture.specification.basic_copyteximage2d.cube_rgba
and ES2-CTS.functional.texture.specification.basic_copytexsubimage2d.cube_rgba
on G45.

Signed-off-by: Ian Romanick <ian.d.romanick@intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101284
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
This commit is contained in:
Jason Ekstrand
2017-05-31 11:29:14 -07:00
committed by Ian Romanick
parent cc14286930
commit b2dd61196e
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/intel/blorp/blorp_blit.c
+6 -2
View File
@@ -1672,11 +1672,15 @@ try_blorp_blit(struct blorp_batch *batch,
/* The MinLOD and MinimumArrayElement don't work properly for cube maps.
* Convert them to a single slice on gen4.
*/
if (params->dst.surf.usage & ISL_SURF_USAGE_CUBE_BIT)
if (params->dst.surf.usage & ISL_SURF_USAGE_CUBE_BIT) {
blorp_surf_convert_to_single_slice(batch->blorp->isl_dev, &params->dst);
wm_prog_key->need_dst_offset = true;
}
if (params->src.surf.usage & ISL_SURF_USAGE_CUBE_BIT)
if (params->src.surf.usage & ISL_SURF_USAGE_CUBE_BIT) {
blorp_surf_convert_to_single_slice(batch->blorp->isl_dev, &params->src);
wm_prog_key->need_src_offset = true;
}
}
if (devinfo->gen > 6 &&