fix some additional program refcounting bugs
cherry-picked from master
This commit is contained in:
@@ -116,8 +116,6 @@ _mesa_free_program_data(GLcontext *ctx)
|
||||
}
|
||||
|
||||
|
||||
|
||||
|
||||
/**
|
||||
* Set the vertex/fragment program error state (position and error string).
|
||||
* This is generally called from within the parsers.
|
||||
@@ -272,6 +270,7 @@ _mesa_delete_program(GLcontext *ctx, struct gl_program *prog)
|
||||
{
|
||||
(void) ctx;
|
||||
ASSERT(prog);
|
||||
ASSERT(prog->RefCount==0);
|
||||
|
||||
if (prog == &_mesa_DummyProgram)
|
||||
return;
|
||||
@@ -391,7 +390,7 @@ _mesa_clone_program(GLcontext *ctx, const struct gl_program *prog)
|
||||
clone->Format = prog->Format;
|
||||
clone->Instructions = _mesa_alloc_instructions(prog->NumInstructions);
|
||||
if (!clone->Instructions) {
|
||||
ctx->Driver.DeleteProgram(ctx, clone);
|
||||
_mesa_reference_program(ctx, &clone, NULL);
|
||||
return NULL;
|
||||
}
|
||||
_mesa_copy_instructions(clone->Instructions, prog->Instructions,
|
||||
|
||||
@@ -245,10 +245,8 @@ _mesa_free_shader(GLcontext *ctx, struct gl_shader *sh)
|
||||
_mesa_free((void *) sh->Source);
|
||||
if (sh->InfoLog)
|
||||
_mesa_free(sh->InfoLog);
|
||||
for (i = 0; i < sh->NumPrograms; i++) {
|
||||
assert(sh->Programs[i]);
|
||||
ctx->Driver.DeleteProgram(ctx, sh->Programs[i]);
|
||||
}
|
||||
for (i = 0; i < sh->NumPrograms; i++)
|
||||
_mesa_reference_program(ctx, &sh->Programs[i], NULL);
|
||||
if (sh->Programs)
|
||||
_mesa_free(sh->Programs);
|
||||
_mesa_free(sh);
|
||||
|
||||
@@ -79,7 +79,7 @@ new_subroutine(slang_emit_info *emitInfo, GLuint *id)
|
||||
_mesa_realloc(emitInfo->Subroutines,
|
||||
n * sizeof(struct gl_program),
|
||||
(n + 1) * sizeof(struct gl_program));
|
||||
emitInfo->Subroutines[n] = _mesa_new_program(ctx, emitInfo->prog->Target, 0);
|
||||
emitInfo->Subroutines[n] = ctx->Driver.NewProgram(ctx, emitInfo->prog->Target, 0);
|
||||
emitInfo->Subroutines[n]->Parameters = emitInfo->prog->Parameters;
|
||||
emitInfo->NumSubroutines++;
|
||||
*id = n;
|
||||
@@ -1787,7 +1787,7 @@ _slang_resolve_subroutines(slang_emit_info *emitInfo)
|
||||
sub->NumInstructions);
|
||||
/* delete subroutine code */
|
||||
sub->Parameters = NULL; /* prevent double-free */
|
||||
_mesa_delete_program(ctx, sub);
|
||||
_mesa_reference_program(ctx, &emitInfo->Subroutines[i], NULL);
|
||||
}
|
||||
|
||||
/* free subroutine list */
|
||||
|
||||
Reference in New Issue
Block a user