nv50,nvc0: free memory allocated by performance metrics
The destroy_query() helper was actually never called. This fixes a memory leak while monitoring performance metrics. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Acked-by: Ilia Mirkin <imirkin@alum.mit.edu> Cc: "11.1" <mesa-stable@lists.freedesktop.org>
This commit is contained in:
@@ -113,6 +113,12 @@ static void
|
||||
nv50_hw_destroy_query(struct nv50_context *nv50, struct nv50_query *q)
|
||||
{
|
||||
struct nv50_hw_query *hq = nv50_hw_query(q);
|
||||
|
||||
if (hq->funcs && hq->funcs->destroy_query) {
|
||||
hq->funcs->destroy_query(nv50, hq);
|
||||
return;
|
||||
}
|
||||
|
||||
nv50_hw_query_allocate(nv50, q, 0);
|
||||
nouveau_fence_ref(NULL, &hq->fence);
|
||||
FREE(hq);
|
||||
|
||||
@@ -71,7 +71,8 @@ nv50_hw_metric_destroy_query(struct nv50_context *nv50,
|
||||
unsigned i;
|
||||
|
||||
for (i = 0; i < hmq->num_queries; i++)
|
||||
hmq->queries[i]->funcs->destroy_query(nv50, hmq->queries[i]);
|
||||
if (hmq->queries[i]->funcs->destroy_query)
|
||||
hmq->queries[i]->funcs->destroy_query(nv50, hmq->queries[i]);
|
||||
FREE(hmq);
|
||||
}
|
||||
|
||||
|
||||
@@ -153,7 +153,9 @@ static void
|
||||
nv50_hw_sm_destroy_query(struct nv50_context *nv50, struct nv50_hw_query *hq)
|
||||
{
|
||||
struct nv50_query *q = &hq->base;
|
||||
q->funcs->destroy_query(nv50, q);
|
||||
nv50_hw_query_allocate(nv50, q, 0);
|
||||
nouveau_fence_ref(NULL, &hq->fence);
|
||||
FREE(hq);
|
||||
}
|
||||
|
||||
static boolean
|
||||
|
||||
@@ -116,6 +116,12 @@ static void
|
||||
nvc0_hw_destroy_query(struct nvc0_context *nvc0, struct nvc0_query *q)
|
||||
{
|
||||
struct nvc0_hw_query *hq = nvc0_hw_query(q);
|
||||
|
||||
if (hq->funcs && hq->funcs->destroy_query) {
|
||||
hq->funcs->destroy_query(nvc0, hq);
|
||||
return;
|
||||
}
|
||||
|
||||
nvc0_hw_query_allocate(nvc0, q, 0);
|
||||
nouveau_fence_ref(NULL, &hq->fence);
|
||||
FREE(hq);
|
||||
|
||||
@@ -293,7 +293,8 @@ nvc0_hw_metric_destroy_query(struct nvc0_context *nvc0,
|
||||
unsigned i;
|
||||
|
||||
for (i = 0; i < hmq->num_queries; i++)
|
||||
hmq->queries[i]->funcs->destroy_query(nvc0, hmq->queries[i]);
|
||||
if (hmq->queries[i]->funcs->destroy_query)
|
||||
hmq->queries[i]->funcs->destroy_query(nvc0, hmq->queries[i]);
|
||||
FREE(hmq);
|
||||
}
|
||||
|
||||
|
||||
@@ -782,7 +782,9 @@ static void
|
||||
nvc0_hw_sm_destroy_query(struct nvc0_context *nvc0, struct nvc0_hw_query *hq)
|
||||
{
|
||||
struct nvc0_query *q = &hq->base;
|
||||
q->funcs->destroy_query(nvc0, q);
|
||||
nvc0_hw_query_allocate(nvc0, q, 0);
|
||||
nouveau_fence_ref(NULL, &hq->fence);
|
||||
FREE(hq);
|
||||
}
|
||||
|
||||
static boolean
|
||||
|
||||
Reference in New Issue
Block a user