Revert "glx: Implement GLX_EXT_no_config_context"

This reverts commit 0d635ccc91.

Gitlab: https://gitlab.freedesktop.org/mesa/mesa/issues/1207

src/glx/applegl_glx.c

@@ -134,9 +134,6 @@ applegl_create_context(struct glx_screen *psc,
    /* TODO: Integrate this with apple_glx_create_context and make
     * struct apple_glx_context inherit from struct glx_context. */
 
-   if (!config)
-      return NULL;
-
    gc = calloc(1, sizeof(*gc));
    if (gc == NULL)
       return NULL;

src/glx/create_context.c

@@ -33,14 +33,6 @@
 #error This code requires sizeof(uint32_t) == sizeof(int).
 #endif
 
-/* debian stretch still has ancient headers and we're apparently still
- * using that for gitlab ci. please delete me when that's fixed.
- */
-#ifndef X_GLXCreateContextAttribsARB
-#warning Please update your GLX protocol headers
-#define X_GLXCreateContextAttribsARB 34
-#endif
-
 _X_HIDDEN GLXContext
 glXCreateContextAttribsARB(Display *dpy, GLXFBConfig config,
 			   GLXContext share_context, Bool direct,
@@ -55,11 +47,21 @@ glXCreateContextAttribsARB(Display *dpy, GLXFBConfig config,
    xcb_generic_error_t *err;
    xcb_void_cookie_t cookie;
    unsigned dummy_err = 0;
-   int screen = -1;
 
-   if (dpy == NULL)
+
+   if (dpy == NULL || cfg == NULL)
       return NULL;
 
+   /* This means that either the caller passed the wrong display pointer or
+    * one of the internal GLX data structures (probably the fbconfig) has an
+    * error.  There is nothing sensible to do, so return an error.
+    */
+   psc = GetGLXScreenConfigs(dpy, cfg->screen);
+   if (psc == NULL)
+      return NULL;
+
+   assert(cfg->screen == psc->scr);
+
    /* Count the number of attributes specified by the application.  All
     * attributes appear in pairs, except the terminating None.
     */
@@ -68,29 +70,6 @@ glXCreateContextAttribsARB(Display *dpy, GLXFBConfig config,
 	 /* empty */ ;
    }
 
-   if (cfg) {
-      screen = cfg->screen;
-   } else {
-      for (unsigned int i = 0; i < num_attribs; i++) {
-         if (attrib_list[i * 2] == GLX_SCREEN)
-            screen = attrib_list[i * 2 + 1];
-      }
-      if (screen == -1) {
-         __glXSendError(dpy, BadValue, 0, X_GLXCreateContextAttribsARB, True);
-         return NULL;
-      }
-   }
-
-   /* This means that either the caller passed the wrong display pointer or
-    * one of the internal GLX data structures (probably the fbconfig) has an
-    * error.  There is nothing sensible to do, so return an error.
-    */
-   psc = GetGLXScreenConfigs(dpy, screen);
-   if (psc == NULL)
-      return NULL;
-
-   assert(screen == psc->scr);
-
    if (direct && psc->vtable->create_context_attribs) {
       /* GLX drops the error returned by the driver.  The expectation is that
        * an error will also be returned by the server.  The server's error
@@ -125,8 +104,8 @@ glXCreateContextAttribsARB(Display *dpy, GLXFBConfig config,
    cookie =
       xcb_glx_create_context_attribs_arb_checked(c,
 						 gc->xid,
-						 cfg ? cfg->fbconfigID : 0,
-						 screen,
+						 cfg->fbconfigID,
+						 cfg->screen,
 						 gc->share_xid,
 						 gc->isDirect,
 						 num_attribs,

src/glx/dri2_glx.c

@@ -1135,7 +1135,6 @@ dri2BindExtensions(struct dri2_screen *psc, struct glx_display * priv,
 
       __glXEnableDirectExtension(&psc->base, "GLX_ARB_create_context");
       __glXEnableDirectExtension(&psc->base, "GLX_ARB_create_context_profile");
-      __glXEnableDirectExtension(&psc->base, "GLX_EXT_no_config_context");
 
       if ((mask & ((1 << __DRI_API_GLES) |
                    (1 << __DRI_API_GLES2) |

src/glx/dri3_glx.c

@@ -750,7 +750,6 @@ dri3_bind_extensions(struct dri3_screen *psc, struct glx_display * priv,
 
    __glXEnableDirectExtension(&psc->base, "GLX_ARB_create_context");
    __glXEnableDirectExtension(&psc->base, "GLX_ARB_create_context_profile");
-   __glXEnableDirectExtension(&psc->base, "GLX_EXT_no_config_context");
 
    if ((mask & ((1 << __DRI_API_GLES) |
                 (1 << __DRI_API_GLES2) |

src/glx/dri_common.c

@@ -500,10 +500,6 @@ dri2_convert_glx_attribs(unsigned num_attribs, const uint32_t *attribs,
             return false;
          }
          break;
-      case GLX_SCREEN:
-         /* Implies GLX_EXT_no_config_context */
-         *render_type = GLX_DONT_CARE;
-         break;
       default:
 	 /* If an unknown attribute is received, fail.
 	  */

src/glx/drisw_glx.c

@@ -789,7 +789,6 @@ driswBindExtensions(struct drisw_screen *psc, const __DRIextension **extensions)
    if (psc->swrast->base.version >= 3) {
       __glXEnableDirectExtension(&psc->base, "GLX_ARB_create_context");
       __glXEnableDirectExtension(&psc->base, "GLX_ARB_create_context_profile");
-      __glXEnableDirectExtension(&psc->base, "GLX_EXT_no_config_context");
 
       /* DRISW version >= 2 implies support for OpenGL ES.
        */

src/glx/driwindows_glx.c

@@ -240,7 +240,7 @@ driwindows_create_context_attribs(struct glx_screen *base,
      identical values, so far
    */
 
-   if (!psc->base.driScreen || !config_base)
+   if (!psc->base.driScreen)
       return NULL;
 
    /* Check the renderType value */

src/glx/g_glxglvnddispatchfuncs.c

@@ -160,19 +160,7 @@ static GLXContext dispatch_CreateContextAttribsARB(Display *dpy,
     __GLXvendorInfo *dd;
     GLXContext ret;
 
-    if (config) {
-       dd = GetDispatchFromFBConfig(dpy, config);
-    } else if (attrib_list) {
-       int i, screen;
-
-       for (i = 0; attrib_list[i * 2] != None; i++) {
-          if (attrib_list[i * 2] == GLX_SCREEN) {
-             screen = attrib_list[i * 2 + 1];
-             dd = GetDispatchFromDrawable(dpy, RootWindow(dpy, screen));
-             break;
-          }
-       }
-    }
+    dd = GetDispatchFromFBConfig(dpy, config);
     if (dd == NULL)
         return None;
 

src/glx/glxcmds.c

@@ -238,7 +238,7 @@ validate_renderType_against_config(const struct glx_config *config,
 {
    /* GLX_EXT_no_config_context supports any render type */
    if (!config)
-      return renderType == GLX_DONT_CARE;
+      return True;
 
    switch (renderType) {
       case GLX_RGBA_TYPE:
@@ -269,9 +269,6 @@ glx_context_init(struct glx_context *gc,
    gc->isDirect = GL_TRUE;
    gc->currentContextTag = -1;
 
-   if (!config)
-      gc->renderType = GLX_DONT_CARE;
-
    return True;
 }
 

src/glx/glxextensions.c

@@ -147,7 +147,6 @@ static const struct extension_info known_glx_extensions[] = {
    { GLX(EXT_fbconfig_packed_float),   VER(0,0), Y, Y, N, N },
    { GLX(EXT_framebuffer_sRGB),        VER(0,0), Y, Y, N, N },
    { GLX(EXT_import_context),          VER(0,0), Y, Y, N, N },
-   { GLX(EXT_no_config_context),       VER(0,0), Y, N, N, N },
    { GLX(EXT_texture_from_pixmap),     VER(0,0), Y, N, N, N },
    { GLX(EXT_visual_info),             VER(0,0), Y, Y, N, N },
    { GLX(EXT_visual_rating),           VER(0,0), Y, Y, N, N },

src/glx/glxextensions.h

@@ -51,7 +51,6 @@ enum
    EXT_fbconfig_packed_float_bit,
    EXT_framebuffer_sRGB_bit,
    EXT_import_context_bit,
-   EXT_no_config_context_bit,
    EXT_texture_from_pixmap_bit,
    EXT_visual_info_bit,
    EXT_visual_rating_bit,

src/glx/tests/create_context_unittest.cpp

@@ -172,6 +172,15 @@ TEST_F(glXCreateContextAttribARB_test, NULL_display_returns_None)
    EXPECT_EQ(0, fake_glx_context::contexts_allocated);
 }
 
+TEST_F(glXCreateContextAttribARB_test, NULL_fbconfig_returns_None)
+{
+   GLXContext ctx =
+      glXCreateContextAttribsARB(this->dpy, NULL, 0, False, NULL);
+
+   EXPECT_EQ(None, ctx);
+   EXPECT_EQ(0, fake_glx_context::contexts_allocated);
+}
+
 TEST_F(glXCreateContextAttribARB_test, NULL_screen_returns_None)
 {
    delete psc;