vulkan/wsi: Drop signal_fence/semaphore_with_memory
Intel was the only drivers setting this and how they don't so we can get rid of the flag and the associated code. Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org> Acked-by: Daniel Stone <daniels@collabora.com> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36783>
This commit is contained in:
@@ -1205,15 +1205,9 @@ wsi_signal_semaphore_for_image(struct vk_device *device,
|
||||
return result;
|
||||
#endif
|
||||
|
||||
if (chain->wsi->signal_semaphore_with_memory) {
|
||||
return device->create_sync_for_memory(device, image->memory,
|
||||
false /* signal_memory */,
|
||||
&semaphore->temporary);
|
||||
} else {
|
||||
return vk_sync_create(device, &vk_sync_dummy_type,
|
||||
0 /* flags */, 0 /* initial_value */,
|
||||
&semaphore->temporary);
|
||||
}
|
||||
return vk_sync_create(device, &vk_sync_dummy_type,
|
||||
0 /* flags */, 0 /* initial_value */,
|
||||
&semaphore->temporary);
|
||||
}
|
||||
|
||||
static VkResult
|
||||
@@ -1241,15 +1235,9 @@ wsi_signal_fence_for_image(struct vk_device *device,
|
||||
return result;
|
||||
#endif
|
||||
|
||||
if (chain->wsi->signal_fence_with_memory) {
|
||||
return device->create_sync_for_memory(device, image->memory,
|
||||
false /* signal_memory */,
|
||||
&fence->temporary);
|
||||
} else {
|
||||
return vk_sync_create(device, &vk_sync_dummy_type,
|
||||
0 /* flags */, 0 /* initial_value */,
|
||||
&fence->temporary);
|
||||
}
|
||||
return vk_sync_create(device, &vk_sync_dummy_type,
|
||||
0 /* flags */, 0 /* initial_value */,
|
||||
&fence->temporary);
|
||||
}
|
||||
|
||||
VkResult
|
||||
|
||||
@@ -185,21 +185,6 @@ struct wsi_device {
|
||||
/* Set to true if the implementation is ok with linear WSI images. */
|
||||
bool wants_linear;
|
||||
|
||||
/* Signals the semaphore such that any wait on the semaphore will wait on
|
||||
* any reads or writes on the give memory object. This is used to
|
||||
* implement the semaphore signal operation in vkAcquireNextImage. This
|
||||
* requires the driver to implement vk_device::create_sync_for_memory.
|
||||
*/
|
||||
bool signal_semaphore_with_memory;
|
||||
|
||||
/* Signals the fence such that any wait on the fence will wait on any reads
|
||||
* or writes on the give memory object. This is used to implement the
|
||||
* semaphore signal operation in vkAcquireNextImage. This requires the
|
||||
* driver to implement vk_device::create_sync_for_memory. The resulting
|
||||
* vk_sync must support CPU waits.
|
||||
*/
|
||||
bool signal_fence_with_memory;
|
||||
|
||||
/* Whether present_wait functionality is enabled on the device.
|
||||
* In this case, we have to create an extra timeline semaphore
|
||||
* to be able to synchronize with the WSI present semaphore being unsignalled.
|
||||
|
||||
Reference in New Issue
Block a user