AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

zink/kopper: Don't recycle unused acquire semaphores

Browse Source 
Fixes: e9f18f64b9 ("zink: also cache swapchain semaphores")
Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36014>
This commit is contained in:
Faith Ekstrand
2025-07-11 16:15:04 -04:00
committed by Marge Bot
parent d978cbf944
commit 8d9675520f
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/gallium/drivers/zink/zink_kopper.c
View File

@@ -150,9 +150,14 @@ destroy_swapchain(struct zink_screen *screen, struct kopper_swapchain *cswap)
return;
util_queue_fence_destroy(&cswap->present_fence);
for (unsigned i = 0; i < cswap->num_images; i++) {
simple_mtx_lock(&screen->semaphores_lock);
util_dynarray_append(&screen->semaphores, VkSemaphore, cswap->images[i].acquire);
simple_mtx_unlock(&screen->semaphores_lock);
/* Destroy the acquire semaphore directly, if any. If acquire != NULL
* then we've called vkAcquireNextImage() with the given semaphore but
* not submitted anything which waits on it. This means the semaphore
* has a pending signal operation and is not safe to recycle.
*/
if (cswap->images[i].acquire != VK_NULL_HANDLE)
VKSCR(DestroySemaphore)(screen->dev, cswap->images[i].acquire, NULL);
pipe_resource_reference(&cswap->images[i].readback, NULL);
zink_destroy_resource_surface_cache(screen, &cswap->images[i].surface_cache, false);
}