AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

radv/sqtt: always dump pipelines and shaders ISA

Browse Source 
Even if instruction timing is disabled, both features are unrelated.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13648>
This commit is contained in:
Samuel Pitoiset
2021-11-03 16:51:49 +01:00
committed by Marge Bot
parent 3aab34171d
commit 8a0052f099
1 changed files with 16 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/amd/vulkan/layers/radv_sqtt_layer.c
+16 -22
View File
@@ -610,8 +610,7 @@ sqtt_CmdBindPipeline(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipeline
API_MARKER(BindPipeline, commandBuffer, pipelineBindPoint, _pipeline);
if (radv_is_instruction_timing_enabled())
radv_describe_pipeline_bind(cmd_buffer, pipelineBindPoint, pipeline);
radv_describe_pipeline_bind(cmd_buffer, pipelineBindPoint, pipeline);
}
VKAPI_ATTR void VKAPI_CALL
@@ -994,17 +993,15 @@ sqtt_CreateGraphicsPipelines(VkDevice _device, VkPipelineCache pipelineCache, ui
if (result != VK_SUCCESS)
return result;
if (radv_is_instruction_timing_enabled()) {
for (unsigned i = 0; i < count; i++) {
RADV_FROM_HANDLE(radv_pipeline, pipeline, pPipelines[i]);
for (unsigned i = 0; i < count; i++) {
RADV_FROM_HANDLE(radv_pipeline, pipeline, pPipelines[i]);
if (!pipeline)
continue;
if (!pipeline)
continue;
result = radv_register_pipeline(device, pipeline);
if (result != VK_SUCCESS)
goto fail;
}
result = radv_register_pipeline(device, pipeline);
if (result != VK_SUCCESS)
goto fail;
}
return VK_SUCCESS;
@@ -1030,17 +1027,15 @@ sqtt_CreateComputePipelines(VkDevice _device, VkPipelineCache pipelineCache, uin
if (result != VK_SUCCESS)
return result;
if (radv_is_instruction_timing_enabled()) {
for (unsigned i = 0; i < count; i++) {
RADV_FROM_HANDLE(radv_pipeline, pipeline, pPipelines[i]);
for (unsigned i = 0; i < count; i++) {
RADV_FROM_HANDLE(radv_pipeline, pipeline, pPipelines[i]);
if (!pipeline)
continue;
if (!pipeline)
continue;
result = radv_register_pipeline(device, pipeline);
if (result != VK_SUCCESS)
goto fail;
}
result = radv_register_pipeline(device, pipeline);
if (result != VK_SUCCESS)
goto fail;
}
return VK_SUCCESS;
@@ -1063,8 +1058,7 @@ sqtt_DestroyPipeline(VkDevice _device, VkPipeline _pipeline,
if (!_pipeline)
return;
if (radv_is_instruction_timing_enabled())
radv_unregister_pipeline(device, pipeline);
radv_unregister_pipeline(device, pipeline);
radv_DestroyPipeline(_device, _pipeline, pAllocator);
}