pan/mdg: Rename bitcount8 to popcnt, fixing the unit

Still doesn't seem to work correctly for negative values.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8774>

src/panfrost/midgard/midgard.h

@@ -128,7 +128,7 @@ typedef enum {
         midgard_alu_op_ixor       = 0x76,
         midgard_alu_op_inxor      = 0x77, /* ~(a & b) */
         midgard_alu_op_iclz       = 0x78, /* Number of zeroes on left */
-        midgard_alu_op_ibitcount8 = 0x7A, /* Counts bits in 8-bit increments */
+        midgard_alu_op_ipopcnt    = 0x7A, /* Population count */
         midgard_alu_op_imov       = 0x7B,
         midgard_alu_op_iabsdiff   = 0x7C,
         midgard_alu_op_uabsdiff   = 0x7D,

src/panfrost/midgard/midgard_ops.c

@@ -136,7 +136,7 @@ struct mir_op_props alu_opcode_props[256] = {
         [midgard_alu_op_ixor]		 = {"ixor", UNITS_MOST | OP_COMMUTES},
         [midgard_alu_op_inxor]		 = {"inxor", UNITS_MOST | OP_COMMUTES},
         [midgard_alu_op_iclz]		 = {"iclz", UNITS_ADD},
-        [midgard_alu_op_ibitcount8]	 = {"ibitcount8", UNITS_ADD},
+        [midgard_alu_op_ipopcnt]	 = {"ipopcnt", UNIT_VADD},
         [midgard_alu_op_inand]		 = {"inand", UNITS_MOST},
         [midgard_alu_op_ishl]		 = {"ishl", UNITS_ADD},
         [midgard_alu_op_iasr]		 = {"iasr", UNITS_ADD},

src/panfrost/midgard/midgard_print_constant.c

@@ -53,7 +53,7 @@ mir_print_constant_component(FILE *fp, const midgard_constants *consts, unsigned
                  * be true for all of them, but it's good enough for traces.
                  */
                 if (op >= midgard_alu_op_iand &&
-                    op <= midgard_alu_op_ibitcount8)
+                    op <= midgard_alu_op_ipopcnt)
                         is_hex = true;
                 else
                         is_sint = true;