AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ir3/legalize: Fix helper propagation with b.any/b.all/getone

Browse Source 
We need to set uses_helpers_beginning in order to propagate it to
predecessor blocks.

Fixes: aa322a37fc ("ir3: Implement helper invocation optimization")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26564>
This commit is contained in:
Connor Abbott
2023-12-07 07:27:12 -05:00
committed by Marge Bot
parent 91ec3cc7e2
commit 862df28f6b
2 changed files with 1 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/freedreno/ci/freedreno-a660-fails.txt
-18
View File
@@ -10,24 +10,6 @@ gmem-dEQP-VK.spirv_assembly.instruction.graphics.variable_pointers.graphics.writ
dEQP-VK.binding_model.descriptor_buffer.basic.limits,Fail
gmem-dEQP-VK.binding_model.descriptor_buffer.basic.limits,Fail
dEQP-VK.subgroups.vote.frag_helper.subgroupallequal_bvec2_fragment,Fail
dEQP-VK.subgroups.vote.frag_helper.subgroupallequal_bvec3_fragment,Fail
dEQP-VK.subgroups.vote.frag_helper.subgroupallequal_bvec4_fragment,Fail
dEQP-VK.subgroups.vote.frag_helper.subgroupallequal_float_fragment,Fail
dEQP-VK.subgroups.vote.frag_helper.subgroupallequal_ivec2_fragment,Fail
dEQP-VK.subgroups.vote.frag_helper.subgroupallequal_ivec3_fragment,Fail
dEQP-VK.subgroups.vote.frag_helper.subgroupallequal_ivec4_fragment,Fail
dEQP-VK.subgroups.vote.frag_helper.subgroupallequal_uvec2_fragment,Fail
dEQP-VK.subgroups.vote.frag_helper.subgroupallequal_uvec3_fragment,Fail
dEQP-VK.subgroups.vote.frag_helper.subgroupallequal_uvec4_fragment,Fail
dEQP-VK.subgroups.vote.frag_helper.subgroupallequal_vec2_fragment,Fail
dEQP-VK.subgroups.vote.frag_helper.subgroupallequal_vec3_fragment,Fail
dEQP-VK.subgroups.vote.frag_helper.subgroupallequal_vec4_fragment,Fail
gmem-dEQP-VK.subgroups.vote.frag_helper.subgroupallequal_ivec4_fragment,Fail
gmem-dEQP-VK.subgroups.vote.frag_helper.subgroupallequal_uvec2_fragment,Fail
gmem-dEQP-VK.subgroups.vote.frag_helper.subgroupallequal_vec2_fragment,Fail
gmem-dEQP-VK.subgroups.vote.frag_helper.subgroupallequal_vec4_fragment,Fail
# New CTS fails in 1.3.6.3
gmem-dEQP-VK.spirv_assembly.instruction.graphics.16bit_storage:struct_mixed_types.uniform_buffer_block_geom,Fail
gmem-dEQP-VK.spirv_assembly.instruction.graphics.16bit_storage.struct_mixed_types.uniform_buffer_block_geom,Fail
src/freedreno/ir3/ir3_legalize.c
+1
View File
@@ -998,6 +998,7 @@ helper_sched(struct ir3_legalize_ctx *ctx, struct ir3 *ir,
if (block->brtype == IR3_BRANCH_ALL ||
block->brtype == IR3_BRANCH_ANY ||
block->brtype == IR3_BRANCH_GETONE) {
bd->uses_helpers_beginning = true;
bd->uses_helpers_end = true;
}