AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

d3d12: Fail-fast on PSO creation failures

Browse Source 
I'm seeing crash reports from the wild where it's not necessarily clear why
something failed, and it'd be nice to have the PSO desc on the stack when
something failed. It ends up being fatal anyway (we don't gracefully drop
draw calls, and I don't think we should).

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35614>
This commit is contained in:
Jesse Natalie
2025-06-18 13:23:19 -07:00
committed by Marge Bot
parent 43d61df19b
commit 856f1d4e3c
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/gallium/drivers/d3d12/d3d12_pipeline_state.cpp
+8 -6
View File
@@ -43,6 +43,7 @@
#include "util/u_prim.h"
#include <dxguids/dxguids.h>
#include <cstdlib>
struct d3d12_gfx_pso_entry {
struct d3d12_gfx_pipeline_state key;
@@ -388,23 +389,24 @@ create_gfx_pipeline_state(struct d3d12_context *ctx)
ID3D12PipelineState *ret;
HRESULT hr;
if (screen->opts14.IndependentFrontAndBackStencilRefMaskSupported) {
D3D12_PIPELINE_STATE_STREAM_DESC pso_stream_desc{
sizeof(pso_desc),
&pso_desc
};
if (FAILED(screen->dev->CreatePipelineState(&pso_stream_desc,
IID_PPV_ARGS(&ret)))) {
debug_printf("D3D12: CreateGraphicsPipelineState failed!\n");
if (FAILED(hr = screen->dev->CreatePipelineState(&pso_stream_desc,
IID_PPV_ARGS(&ret)))) {
std::_Exit(hr);
return NULL;
}
}
else {
D3D12_GRAPHICS_PIPELINE_STATE_DESC v0desc = pso_desc.GraphicsDescV0();
if (FAILED(screen->dev->CreateGraphicsPipelineState(&v0desc,
IID_PPV_ARGS(&ret)))) {
debug_printf("D3D12: CreateGraphicsPipelineState failed!\n");
if (FAILED(hr = screen->dev->CreateGraphicsPipelineState(&v0desc,
IID_PPV_ARGS(&ret)))) {
std::_Exit(hr);
return NULL;
}
}