AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Revert "intel: Always set Cube Face Enables for all surfaces."

Browse Source 
This reverts commit bf15dc7a1b.

All credit goes to Lionel, he spotted this difference. How much effort
went in for this god knows.

Closes: #12348 #12816 #12446 #12387 #12827 Related #12847 #12520
Cc: mesa-stable
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37498>
This commit is contained in:
Sagar Ghuge
2025-10-13 11:24:19 -07:00
parent dce859a183
commit 77d2197c18
1 changed files with 18 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/intel/isl/isl_surface_state.c
View File

@@ -560,12 +560,24 @@ isl_genX(surf_fill_state_s)(const struct isl_device *dev, void *state,
s.EnableUnormPathInColorPipe = true;
#endif
s.CubeFaceEnablePositiveZ = 1;
s.CubeFaceEnableNegativeZ = 1;
s.CubeFaceEnablePositiveY = 1;
s.CubeFaceEnableNegativeY = 1;
s.CubeFaceEnablePositiveX = 1;
s.CubeFaceEnableNegativeX = 1;
/*
* Bspec 57023, RENDER_SURFACE_STATE, bit fields CubeFaceEnable*
* states that:
*
* This field must be programmed to 1h (enabled) whenever Surface Type is
* programmed to SURFTYPE_CUBE
*
* This used to work fine for non-cube surfaces on older hardware but on
* Xe2+, looks like this restriction is pretty strict.
*/
if (info->view->usage & ISL_SURF_USAGE_CUBE_BIT) {
s.CubeFaceEnablePositiveZ = 1;
s.CubeFaceEnableNegativeZ = 1;
s.CubeFaceEnablePositiveY = 1;
s.CubeFaceEnableNegativeY = 1;
s.CubeFaceEnablePositiveX = 1;
s.CubeFaceEnableNegativeX = 1;
}
#if GFX_VER >= 6
/* From the Broadwell PRM for "Number of Multisamples":