ilo: remove intel_bo_get_size()

Commit bfa8d21759 uses it to work around a
hardware limitation.  But there are other ways to do it without the need for
intel_bo_get_size().
This commit is contained in:
Chia-I Wu
2014-03-08 17:22:45 +08:00
parent 790c32ec75
commit 76713ed5d6
4 changed files with 18 additions and 27 deletions
+1 -14
View File
@@ -731,20 +731,7 @@ gen6_emit_3DSTATE_VERTEX_BUFFERS(const struct ilo_dev_info *dev,
if (cso->buffer && cso->stride <= 2048) {
const struct ilo_buffer *buf = ilo_buffer(cso->buffer);
const uint32_t start_offset = cso->buffer_offset;
/*
* As noted in ilo_translate_format(), we treat some 3-component
* formats as 4-component formats to work around hardware
* limitations. Imagine the case where the vertex buffer holds a
* single PIPE_FORMAT_R16G16B16_FLOAT vertex, and buf->bo_size is 6.
* The hardware would not be able to fetch it because the vertex
* buffer is expected to hold a PIPE_FORMAT_R16G16B16A16_FLOAT vertex
* and that takes at least 8 bytes.
*
* For the workaround to work, we query the physical size, which is
* page aligned, to calculate end_offset so that the last vertex has
* a better chance to be fetched.
*/
const uint32_t end_offset = intel_bo_get_size(buf->bo) - 1;
const uint32_t end_offset = buf->bo_size - 1;
dw |= cso->stride << BRW_VB0_PITCH_SHIFT;
+17
View File
@@ -1385,6 +1385,23 @@ buf_create(struct pipe_screen *screen, const struct pipe_resource *templ)
if (templ->bind & PIPE_BIND_SAMPLER_VIEW)
buf->bo_size = align(buf->bo_size, 256) + 16;
if (templ->bind & PIPE_BIND_VERTEX_BUFFER) {
/*
* As noted in ilo_translate_format(), we treat some 3-component formats
* as 4-component formats to work around hardware limitations. Imagine
* the case where the vertex buffer holds a single
* PIPE_FORMAT_R16G16B16_FLOAT vertex, and buf->bo_size is 6. The
* hardware would fail to fetch it at boundary check because the vertex
* buffer is expected to hold a PIPE_FORMAT_R16G16B16A16_FLOAT vertex
* and that takes at least 8 bytes.
*
* For the workaround to work, we should add 2 to the bo size. But that
* would waste a page when the bo size is already page aligned. Let's
* round it to page size for now and revisit this when needed.
*/
buf->bo_size = align(buf->bo_size, 4096);
}
if (!buf_create_bo(buf)) {
FREE(buf);
return NULL;
@@ -405,12 +405,6 @@ intel_bo_unreference(struct intel_bo *bo)
drm_intel_bo_unreference(gem_bo(bo));
}
unsigned long
intel_bo_get_size(const struct intel_bo *bo)
{
return gem_bo(bo)->size;
}
void *
intel_bo_map(struct intel_bo *bo, bool write_enable)
{
-7
View File
@@ -197,13 +197,6 @@ intel_bo_reference(struct intel_bo *bo);
void
intel_bo_unreference(struct intel_bo *bo);
/**
* Return the real size of \p bo. It may be larger than the size specified
* in allocation due to alignment and padding requirements.
*/
unsigned long
intel_bo_get_size(const struct intel_bo *bo);
/**
* Map \p bo for CPU access. Recursive mapping is allowed.
*