AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mesa/main: fix validation of transform-feedback overflow queries

Browse Source 
ctx->Extensions.ARB_transform_feedback_overflow_query is set based on
the driver-capabilities, not based on the context type. We need to
check against _mesa_has_RB_transform_feedback_overflow_query(ctx)
instead to figure out if the extension is really supported.

This turns usage of GL_TRANSFORM_FEEDBACK_STREAM_OVERFLOW and
GL_TRANSFORM_FEEDBACK_OVERFLOW into errors on ES 3, as required by the
spec.

Signed-off-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: Tapani Pälli <tapani.palli@intel.com>
This commit is contained in:
Erik Faye-Lund
2018-11-07 16:00:59 +01:00
parent f09d94fbd1
commit 75e39b59dc
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/mesa/main/queryobj.c
+2 -2
View File
@@ -214,12 +214,12 @@ get_query_binding_point(struct gl_context *ctx, GLenum target, GLuint index)
else
return NULL;
case GL_TRANSFORM_FEEDBACK_STREAM_OVERFLOW:
if (ctx->Extensions.ARB_transform_feedback_overflow_query)
if (_mesa_has_ARB_transform_feedback_overflow_query(ctx))
return &ctx->Query.TransformFeedbackOverflow[index];
else
return NULL;
case GL_TRANSFORM_FEEDBACK_OVERFLOW:
if (ctx->Extensions.ARB_transform_feedback_overflow_query)
if (_mesa_has_ARB_transform_feedback_overflow_query(ctx))
return &ctx->Query.TransformFeedbackOverflowAny;
else
return NULL;