AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

mesa: glsl: additional type checking for assignments, inequalities

Browse Source
This commit is contained in:
Brian Paul
2008-08-05 20:12:50 -06:00
parent bf3040d476
commit 6b888a10d3
1 changed files with 16 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/mesa/shader/slang/slang_codegen.c
+16
View File
@@ -2889,6 +2889,10 @@ _slang_assignment_compatible(slang_assemble_ctx *A,
t0.spec._struct->a_name != t1.spec._struct->a_name)
return GL_FALSE;
if (t0.spec.type == SLANG_SPEC_FLOAT &&
t1.spec.type == SLANG_SPEC_BOOL)
return GL_FALSE;
#if 0 /* not used just yet - causes problems elsewhere */
if (t0.spec.type == SLANG_SPEC_INT &&
t1.spec.type == SLANG_SPEC_FLOAT)
@@ -3237,6 +3241,18 @@ _slang_gen_compare(slang_assemble_ctx *A, slang_operation *oper,
return NULL;
}
if (oper->type != SLANG_OPER_EQUAL &&
oper->type != SLANG_OPER_NOTEQUAL) {
/* <, <=, >, >= can only be used with scalars */
if ((t0.spec.type != SLANG_SPEC_INT &&
t0.spec.type != SLANG_SPEC_FLOAT) ||
(t1.spec.type != SLANG_SPEC_INT &&
t1.spec.type != SLANG_SPEC_FLOAT)) {
slang_info_log_error(A->log, "Illegal type(s) for inequality operator");
return NULL;
}
}
n = new_node2(opcode,
_slang_gen_operation(A, &oper->children[0]),
_slang_gen_operation(A, &oper->children[1]));