AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cso: remove CSO_UNBIND_VERTEX_BUFFER0

Browse Source 
It has no effect other than unreferencing buffers, which are then
immediatelly re-bound by st/mesa, so it doesn't do anything.
The name is also incorrect because it unbound all vertex buffers.

Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27492>
This commit is contained in:
Marek Olšák
2024-02-04 22:24:07 -05:00
committed by Marge Bot
parent 47b15d83a2
commit 6ab25f5cde
4 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/gallium/auxiliary/cso_cache/cso_context.c
-2
View File
@@ -1739,8 +1739,6 @@ cso_restore_state(struct cso_context *ctx, unsigned unbind)
cso->base.pipe->set_constant_buffer(cso->base.pipe, PIPE_SHADER_FRAGMENT, 0, false, NULL);
if (state_mask & CSO_BIT_VERTEX_ELEMENTS)
cso_restore_vertex_elements(cso);
if (unbind & CSO_UNBIND_VERTEX_BUFFER0)
cso->base.pipe->set_vertex_buffers(cso->base.pipe, 0, false, NULL);
if (state_mask & CSO_BIT_STREAM_OUTPUTS)
cso_restore_stream_outputs(cso);
if (state_mask & CSO_BIT_PAUSE_QUERIES)
src/gallium/auxiliary/cso_cache/cso_context.h
-1
View File
@@ -110,7 +110,6 @@ enum cso_unbind_flags {
CSO_UNBIND_FS_IMAGE0 = (1 << 2),
CSO_UNBIND_VS_CONSTANTS = (1 << 3),
CSO_UNBIND_FS_CONSTANTS = (1 << 4),
CSO_UNBIND_VERTEX_BUFFER0 = (1 << 5),
};
/*
src/gallium/auxiliary/hud/hud_context.c
+1 -1
View File
@@ -655,7 +655,7 @@ hud_draw_results(struct hud_context *hud, struct pipe_resource *tex)
}
done:
cso_restore_state(cso, CSO_UNBIND_FS_SAMPLERVIEW0 | CSO_UNBIND_VS_CONSTANTS | CSO_UNBIND_VERTEX_BUFFER0);
cso_restore_state(cso, CSO_UNBIND_FS_SAMPLERVIEW0 | CSO_UNBIND_VS_CONSTANTS);
/* restore states not restored by cso */
if (hud->st) {
src/gallium/auxiliary/postprocess/pp_run.c
+1 -2
View File
@@ -188,8 +188,7 @@ pp_run(struct pp_queue_t *ppq, struct pipe_resource *in,
cso_restore_state(cso, CSO_UNBIND_FS_SAMPLERVIEWS |
CSO_UNBIND_FS_IMAGE0 |
CSO_UNBIND_VS_CONSTANTS |
CSO_UNBIND_FS_CONSTANTS |
CSO_UNBIND_VERTEX_BUFFER0);
CSO_UNBIND_FS_CONSTANTS);
/* restore states not restored by cso */
if (ppq->p->st) {