AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

asahi: assert guard previously-subtle code

Browse Source 
would've caught the bug in the previous patch.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/31908>
This commit is contained in:
Alyssa Rosenzweig
2024-10-28 20:25:17 -04:00
parent 09fde905a0
commit 6a27a3838c
1 changed files with 8 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/gallium/drivers/asahi/agx_state.c
+8
View File
@@ -5021,6 +5021,10 @@ agx_draw_vbo(struct pipe_context *pctx, const struct pipe_draw_info *info,
(ctx->dirty & AGX_DIRTY_VERTEX))
ctx->dirty |= AGX_DIRTY_VS;
/* This is subtle. But agx_update_vs will be true at least once per batch. */
assert(agx_batch_uses_bo(batch, ctx->vs->bo));
assert(!ctx->linked.vs || agx_batch_uses_bo(batch, ctx->linked.vs->bo));
agx_update_gs(ctx, info, indirect);
if (ctx->gs) {
@@ -5065,6 +5069,10 @@ agx_draw_vbo(struct pipe_context *pctx, const struct pipe_draw_info *info,
ctx->dirty |= AGX_DIRTY_FS;
}
/* This is subtle. But agx_update_fs will be true at least once per batch. */
assert(!ctx->fs->bo || agx_batch_uses_bo(batch, ctx->fs->bo));
assert(agx_batch_uses_bo(batch, ctx->linked.fs->bo));
if (ctx->linked.vs->uses_base_param || ctx->gs) {
agx_upload_draw_params(batch, indirect, draws, info);