broadcom/qpu: return false on qpu_writes_accumulatorXX helpers for v71
As for v71 doesn't have accumulators (devinfo->has_accumulators set to false), those methods would always return false. Reviewed-by: Iago Toral Quiroga <itoral@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25450>
This commit is contained in:
committed by
Marge Bot
parent
d7b15c2b42
commit
68526423fb
@@ -854,6 +854,9 @@ bool
|
||||
v3d_qpu_writes_r3(const struct v3d_device_info *devinfo,
|
||||
const struct v3d_qpu_instr *inst)
|
||||
{
|
||||
if(!devinfo->has_accumulators)
|
||||
return false;
|
||||
|
||||
if (qpu_writes_magic_waddr_explicitly(devinfo, inst, V3D_QPU_WADDR_R3))
|
||||
return true;
|
||||
|
||||
@@ -864,6 +867,9 @@ bool
|
||||
v3d_qpu_writes_r4(const struct v3d_device_info *devinfo,
|
||||
const struct v3d_qpu_instr *inst)
|
||||
{
|
||||
if (!devinfo->has_accumulators)
|
||||
return false;
|
||||
|
||||
if (inst->type == V3D_QPU_INSTR_TYPE_ALU) {
|
||||
if (inst->alu.add.op != V3D_QPU_A_NOP &&
|
||||
inst->alu.add.magic_write &&
|
||||
@@ -894,6 +900,9 @@ bool
|
||||
v3d_qpu_writes_r5(const struct v3d_device_info *devinfo,
|
||||
const struct v3d_qpu_instr *inst)
|
||||
{
|
||||
if (!devinfo->has_accumulators)
|
||||
return false;
|
||||
|
||||
if (qpu_writes_magic_waddr_explicitly(devinfo, inst, V3D_QPU_WADDR_R5))
|
||||
return true;
|
||||
|
||||
@@ -904,6 +913,9 @@ bool
|
||||
v3d_qpu_writes_accum(const struct v3d_device_info *devinfo,
|
||||
const struct v3d_qpu_instr *inst)
|
||||
{
|
||||
if (!devinfo->has_accumulators)
|
||||
return false;
|
||||
|
||||
if (v3d_qpu_writes_r5(devinfo, inst))
|
||||
return true;
|
||||
if (v3d_qpu_writes_r4(devinfo, inst))
|
||||
|
||||
Reference in New Issue
Block a user