AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

panfrost: Split panfrost_batch_submit to prevent stack overflows

Browse Source 
panfrost_batch_submit can recurse to hundreds of levels to submit
dependencies, so split the actual submit code from the dependency
recursion, saving over a kilobyte of stack space per recursion
level. Enforce this with ATTRIBUTE_NOINLINE.

Use ATTRIBUTE_NOINLINE on panfrost_batch_submit itself as well to
prevent GCC from inlining the function into itself, which would use a
few hundred bytes of stack.

Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10574>
This commit is contained in:
Icecream95
2021-04-23 23:48:00 +12:00
committed by Marge Bot
parent 8b31092bcd
commit 64246c3ae4
1 changed files with 22 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/gallium/drivers/panfrost/pan_job.c
+22 -14
View File
@@ -1093,21 +1093,11 @@ panfrost_batch_submit_jobs(struct panfrost_batch *batch,
return ret;
}
static void
panfrost_batch_submit(struct panfrost_batch *batch,
uint32_t in_sync, uint32_t out_sync)
static void ATTRIBUTE_NOINLINE
panfrost_batch_submit_nodep(struct panfrost_device *dev,
struct panfrost_batch *batch,
uint32_t in_sync, uint32_t out_sync)
{
assert(batch);
struct panfrost_device *dev = pan_device(batch->ctx->base.screen);
/* Submit the dependencies first. Don't pass along the out_sync since
* they are guaranteed to terminate sooner */
util_dynarray_foreach(&batch->dependencies,
struct panfrost_batch_fence *, dep) {
if ((*dep)->batch)
panfrost_batch_submit((*dep)->batch, 0, 0);
}
int ret;
/* Nothing to do! */
@@ -1170,6 +1160,24 @@ out:
panfrost_free_batch(batch);
}
static void ATTRIBUTE_NOINLINE
panfrost_batch_submit(struct panfrost_batch *batch,
uint32_t in_sync, uint32_t out_sync)
{
assert(batch);
struct panfrost_device *dev = pan_device(batch->ctx->base.screen);
/* Submit the dependencies first. Don't pass along the out_sync since
* they are guaranteed to terminate sooner */
util_dynarray_foreach(&batch->dependencies,
struct panfrost_batch_fence *, dep) {
if ((*dep)->batch)
panfrost_batch_submit((*dep)->batch, 0, 0);
}
panfrost_batch_submit_nodep(dev, batch, in_sync, out_sync);
}
/* Submit all batches, applying the out_sync to the currently bound batch */
void