clover/device: Calculate CL_DEVICE_MEM_BASE_ADDR_ALIGN in device
The CL CTS queries CL_DEVICE_MEM_BASE_ADDR_ALIGN for a device and
then allocates user pointers aligned to that value for its tests.
The minimum value is defined as:
the size (in bits) of the largest OpenCL built-in data type supported
by the device (long16 in FULL profile, long16 or int16 in EMBEDDED
profile) for devices that are not of type CL_DEVICE_TYPE_CUSTOM.
At the moment, all known devices that support user pointers require
CPU page alignment for buffers created from user pointers, so just
query that from sysconf.
v3: Use std::max instead of MAX2 (Francisco)
Add missing unistd include
v2: Use system page size instead of a new pipe cap
Signed-off-by: Aaron Watry <awatry@gmail.com>
Reviewed-by: Francisco Jerez <currojerez@riseup.net>
Reviewed-by (v2): Jan Vesely <jan.vesely@rutgers.edu>
This commit is contained in:
@@ -205,7 +205,8 @@ clGetDeviceInfo(cl_device_id d_dev, cl_device_info param,
|
||||
break;
|
||||
|
||||
case CL_DEVICE_MEM_BASE_ADDR_ALIGN:
|
||||
buf.as_scalar<cl_uint>() = 128 * 8;
|
||||
buf.as_scalar<cl_uint>() = 8 *
|
||||
std::max(dev.mem_base_addr_align(), (cl_uint) sizeof(cl_long) * 16);
|
||||
break;
|
||||
|
||||
case CL_DEVICE_MIN_DATA_TYPE_ALIGN_SIZE:
|
||||
|
||||
@@ -20,6 +20,7 @@
|
||||
// OTHER DEALINGS IN THE SOFTWARE.
|
||||
//
|
||||
|
||||
#include <unistd.h>
|
||||
#include "core/device.hpp"
|
||||
#include "core/platform.hpp"
|
||||
#include "pipe/p_screen.h"
|
||||
@@ -194,6 +195,11 @@ device::has_unified_memory() const {
|
||||
return pipe->get_param(pipe, PIPE_CAP_UMA);
|
||||
}
|
||||
|
||||
cl_uint
|
||||
device::mem_base_addr_align() const {
|
||||
return sysconf(_SC_PAGESIZE);
|
||||
}
|
||||
|
||||
std::vector<size_t>
|
||||
device::max_block_size() const {
|
||||
auto v = get_compute_param<uint64_t>(pipe, ir_format(),
|
||||
|
||||
@@ -68,6 +68,7 @@ namespace clover {
|
||||
bool image_support() const;
|
||||
bool has_doubles() const;
|
||||
bool has_unified_memory() const;
|
||||
cl_uint mem_base_addr_align() const;
|
||||
|
||||
std::vector<size_t> max_block_size() const;
|
||||
cl_uint subgroup_size() const;
|
||||
|
||||
Reference in New Issue
Block a user