broadcom/compiler: update comment on load_uniform fast-path
The comment for 16-bit applies to 8-bit uniforms as well. Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14648>
This commit is contained in:
committed by
Marge Bot
parent
296fde31aa
commit
5cec893384
@@ -2648,11 +2648,12 @@ ntq_emit_load_uniform(struct v3d_compile *c, nir_intrinsic_instr *instr)
|
||||
nir_src_as_uint(instr->src[0]));
|
||||
|
||||
/* Even though ldunif is strictly 32-bit we can still use it
|
||||
* to load scalar 16-bit uniforms so long as their offset is
|
||||
* 32-bit aligned. In this case, ldunif would still load 32-bit
|
||||
* into the destination with the 16-bit uniform data in the LSB
|
||||
* and garbage in the MSB, but that is fine because we don't
|
||||
* access the MSB of a 16-bit register.
|
||||
* to load scalar 8-bit/16-bit uniforms so long as their offset
|
||||
* is * 32-bit aligned. In this case, ldunif would still load
|
||||
* 32-bit into the destination with the 8-bit/16-bit uniform
|
||||
* data in the LSB and garbage in the MSB, but that is fine
|
||||
* because we should only be accessing the valid bits of the
|
||||
* destination.
|
||||
*
|
||||
* FIXME: if in the future we improve our register allocator to
|
||||
* pack 2 16-bit variables in the MSB and LSB of the same
|
||||
|
||||
Reference in New Issue
Block a user