AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

freedreno/a5xx: Fix border color structure size.

Browse Source 
This now matches a6xx.  This major border color flakiness in deqp -- when
a prior test in the caselist bound a VS and it didn't get unbound at the
gallium level, our FS border colors would be up at offset 8 instead of 0,
and the wrong padding would make FS sampler 0 get a junk border color.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24358>
This commit is contained in:
Emma Anholt
2023-07-27 15:23:25 -07:00
committed by Marge Bot
parent 1b66ebf09a
commit 59e9909cc1
3 changed files with 2 additions and 121 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/freedreno/ci/freedreno-a530-fails.txt
-114
View File
@@ -206,103 +206,6 @@ dEQP-GLES31.functional.separate_shader.random.99,Fail
dEQP-GLES31.functional.synchronization.inter_call.without_memory_barrier.ssbo_atomic_dispatch_2_calls_32k_invocations,Fail
dEQP-GLES31.functional.texture.border_clamp.depth_compare_mode.depth_component16.gather_size_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.depth_compare_mode.depth_component16.linear_size_pot,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.bgra.linear_size_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.bgra.linear_size_pot,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.bgra.nearest_size_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.bgra.nearest_size_pot,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.compressed_rgb8_etc2.gather_size_not_tile_multiple,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.compressed_rgb8_etc2.gather_size_tile_multiple,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.compressed_rgb8_etc2.linear_size_not_tile_multiple,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.compressed_rgb8_etc2.linear_size_tile_multiple,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.compressed_rgb8_etc2.nearest_size_not_tile_multiple,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.compressed_rgb8_etc2.nearest_size_tile_multiple,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.compressed_rgb8_punchthrough_alpha1_etc2.gather_size_not_tile_multiple,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.compressed_rgb8_punchthrough_alpha1_etc2.gather_size_tile_multiple,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.compressed_rgb8_punchthrough_alpha1_etc2.linear_size_not_tile_multiple,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.compressed_rgb8_punchthrough_alpha1_etc2.linear_size_tile_multiple,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.compressed_rgb8_punchthrough_alpha1_etc2.nearest_size_not_tile_multiple,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.compressed_rgb8_punchthrough_alpha1_etc2.nearest_size_tile_multiple,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.compressed_rgba8_etc2_eac.gather_size_not_tile_multiple,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.depth24_stencil8_sample_stencil.nearest_size_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.depth_component32f.nearest_size_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.luminance_alpha.gather_size_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.r16i.nearest_size_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.r16ui.nearest_size_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.r16ui.nearest_size_pot,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.r32ui.nearest_size_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.r8.gather_size_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.r8.gather_size_pot,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.r8_snorm.linear_size_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.r8_snorm.nearest_size_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.r8_snorm.nearest_size_pot,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.rg32ui.nearest_size_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.rg32ui.nearest_size_pot,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.rgb10_a2.linear_size_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.rgb10_a2.nearest_size_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.rgb10_a2.nearest_size_pot,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.rgb16f.linear_size_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.rgb16f.linear_size_pot,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.rgb16f.nearest_size_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.rgb16f.nearest_size_pot,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.rgb16i.nearest_size_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.rgb16ui.nearest_size_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.rgb16ui.nearest_size_pot,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.rgb565.gather_size_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.rgb565.gather_size_pot,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.rgb8i.nearest_size_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.rgba32ui.nearest_size_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.rgba4.linear_size_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.rgba4.nearest_size_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.rgba4.nearest_size_pot,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.rgba8i.nearest_size_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.rgba8_snorm.gather_size_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.formats.rgba8_snorm.gather_size_pot,Fail
dEQP-GLES31.functional.texture.border_clamp.per_axis_wrap_mode.texture_2d.compressed_color.linear.s_clamp_to_edge_t_clamp_to_border_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.per_axis_wrap_mode.texture_2d.compressed_color.linear.s_clamp_to_edge_t_clamp_to_border_pot,Fail
dEQP-GLES31.functional.texture.border_clamp.per_axis_wrap_mode.texture_2d.compressed_color.nearest.s_mirrored_repeat_t_clamp_to_border_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.per_axis_wrap_mode.texture_2d.compressed_color.nearest.s_mirrored_repeat_t_clamp_to_border_pot,Fail
dEQP-GLES31.functional.texture.border_clamp.per_axis_wrap_mode.texture_2d.compressed_color.nearest.s_repeat_t_clamp_to_border_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.per_axis_wrap_mode.texture_2d.float_color.nearest.s_mirrored_repeat_t_clamp_to_border_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.per_axis_wrap_mode.texture_2d.float_color.nearest.s_mirrored_repeat_t_clamp_to_border_pot,Fail
dEQP-GLES31.functional.texture.border_clamp.per_axis_wrap_mode.texture_2d.float_color.nearest.s_repeat_t_clamp_to_border_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.per_axis_wrap_mode.texture_2d.int_color.nearest.s_mirrored_repeat_t_clamp_to_border_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.per_axis_wrap_mode.texture_2d.int_color.nearest.s_mirrored_repeat_t_clamp_to_border_pot,Fail
dEQP-GLES31.functional.texture.border_clamp.per_axis_wrap_mode.texture_2d.int_color.nearest.s_repeat_t_clamp_to_border_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.per_axis_wrap_mode.texture_2d.snorm_color.gather.s_clamp_to_edge_t_clamp_to_border_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.per_axis_wrap_mode.texture_2d.snorm_color.gather.s_clamp_to_edge_t_clamp_to_border_pot,Fail
dEQP-GLES31.functional.texture.border_clamp.per_axis_wrap_mode.texture_2d.snorm_color.linear.s_mirrored_repeat_t_clamp_to_border_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.per_axis_wrap_mode.texture_2d.snorm_color.linear.s_mirrored_repeat_t_clamp_to_border_pot,Fail
dEQP-GLES31.functional.texture.border_clamp.per_axis_wrap_mode.texture_2d.snorm_color.linear.s_repeat_t_clamp_to_border_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.per_axis_wrap_mode.texture_2d.snorm_color.linear.s_repeat_t_clamp_to_border_pot,Fail
dEQP-GLES31.functional.texture.border_clamp.per_axis_wrap_mode.texture_2d.snorm_color.nearest.s_clamp_to_edge_t_clamp_to_border_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.per_axis_wrap_mode.texture_2d.unorm_depth.gather.s_clamp_to_edge_t_clamp_to_border_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.per_axis_wrap_mode.texture_3d.float_color.nearest.s_clamp_to_border_t_clamp_to_border_r_clamp_to_border_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.per_axis_wrap_mode.texture_3d.float_color.nearest.s_clamp_to_border_t_clamp_to_border_r_clamp_to_border_pot,Fail
dEQP-GLES31.functional.texture.border_clamp.per_axis_wrap_mode.texture_3d.float_color.nearest.s_clamp_to_border_t_clamp_to_border_r_repeat_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.per_axis_wrap_mode.texture_3d.float_color.nearest.s_clamp_to_border_t_clamp_to_border_r_repeat_pot,Fail
dEQP-GLES31.functional.texture.border_clamp.per_axis_wrap_mode.texture_3d.float_color.nearest.s_mirrored_repeat_t_clamp_to_border_r_repeat_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.per_axis_wrap_mode.texture_3d.uint_color.nearest.s_clamp_to_border_t_clamp_to_border_r_clamp_to_border_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.per_axis_wrap_mode.texture_3d.unorm_color.linear.s_clamp_to_border_t_clamp_to_border_r_clamp_to_border_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.per_axis_wrap_mode.texture_3d.unorm_color.linear.s_clamp_to_border_t_clamp_to_border_r_clamp_to_border_pot,Fail
dEQP-GLES31.functional.texture.border_clamp.per_axis_wrap_mode.texture_3d.unorm_color.linear.s_clamp_to_border_t_clamp_to_border_r_repeat_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.per_axis_wrap_mode.texture_3d.unorm_color.linear.s_clamp_to_border_t_clamp_to_border_r_repeat_pot,Fail
dEQP-GLES31.functional.texture.border_clamp.per_axis_wrap_mode.texture_3d.unorm_color.linear.s_mirrored_repeat_t_clamp_to_border_r_repeat_npot,Fail
dEQP-GLES31.functional.texture.border_clamp.sampler.float_color,Fail
dEQP-GLES31.functional.texture.border_clamp.sampler.int_color,Fail
dEQP-GLES31.functional.texture.border_clamp.sampler.snorm_color,Fail
dEQP-GLES31.functional.texture.border_clamp.sampler.uint_color,Fail
dEQP-GLES31.functional.texture.border_clamp.sampler.unorm_color,Fail
dEQP-GLES31.functional.texture.border_clamp.unused_channels.compressed_r11_eac,Fail
dEQP-GLES31.functional.texture.border_clamp.unused_channels.depth24_stencil8_sample_depth,Fail
dEQP-GLES31.functional.texture.border_clamp.unused_channels.depth24_stencil8_sample_stencil,Fail
dEQP-GLES31.functional.texture.border_clamp.unused_channels.depth32f_stencil8_sample_stencil,Fail
dEQP-GLES31.functional.texture.border_clamp.unused_channels.luminance,Fail
dEQP-GLES31.functional.texture.border_clamp.unused_channels.r16i,Fail
dEQP-GLES31.functional.texture.border_clamp.unused_channels.rg32f,Fail
dEQP-GLES31.functional.texture.border_clamp.unused_channels.rg8_snorm,Fail
dEQP-GLES31.functional.texture.border_clamp.unused_channels.rgb8,Fail
dEQP-GLES31.functional.ubo.random.all_per_block_buffers.20,Fail
# Draws white instead of gradient
@@ -337,23 +240,6 @@ KHR-GLES31.core.shader_storage_buffer_object.basic-stdLayout_UBO_SSBO-case2-cs,F
KHR-GLES31.core.shader_storage_buffer_object.basic-syntax-cs,Fail
KHR-GLES31.core.texture_border_clamp.Texture2DArrayCompressed,Fail
KHR-GLES31.core.texture_border_clamp.Texture2DArrayR32I,Fail
KHR-GLES31.core.texture_border_clamp.Texture2DArrayR32UI,Fail
KHR-GLES31.core.texture_border_clamp.Texture2DArrayRGBA32F,Fail
KHR-GLES31.core.texture_border_clamp.Texture2DArrayRGBA8,Fail
KHR-GLES31.core.texture_border_clamp.Texture2DCompressed,Fail
KHR-GLES31.core.texture_border_clamp.Texture2DDC16,Fail
KHR-GLES31.core.texture_border_clamp.Texture2DDC32F,Fail
KHR-GLES31.core.texture_border_clamp.Texture2DR32I,Fail
KHR-GLES31.core.texture_border_clamp.Texture2DR32UI,Fail
KHR-GLES31.core.texture_border_clamp.Texture2DRGBA32F,Fail
KHR-GLES31.core.texture_border_clamp.Texture2DRGBA8,Fail
KHR-GLES31.core.texture_border_clamp.Texture3DR32I,Fail
KHR-GLES31.core.texture_border_clamp.Texture3DR32UI,Fail
KHR-GLES31.core.texture_border_clamp.Texture3DRGBA32F,Fail
KHR-GLES31.core.texture_border_clamp.Texture3DRGBA8,Fail
# msm 900000.mdss: [drm:a5xx_irq] *ERROR* gpu fault ring 0 fence 2c54ef status E40801C1 rb 0162/0162 ib1 000000000104B000/0000 ib2 000000000104C000/0000
KHR-GLES31.core.texture_buffer.texture_buffer_atomic_functions,Fail
src/freedreno/ci/freedreno-a530-flakes.txt
-5
View File
@@ -19,13 +19,8 @@ dEQP-GLES31.functional.image_load_store.3d.load_store.*_single_layer
# Separate shader and atomics flakiness increased since bfeb0983d3b3 ("ci/freedreno: Disable flaky a530 for now.")
dEQP-GLES31.functional.separate_shader.*
# Flaky since running more of GLES31
dEQP-GLES31.functional.texture.border_clamp.*
KHR-GLES31.core.compute_shader.resource-image
KHR-GLES31.core.texture_border_clamp.*
# Occasionally passes
dEQP-GLES31.functional.draw_base_vertex.draw_elements_instanced_base_vertex.builtin_variable.vertex_id
KHR-GLES31.core.arrays_of_arrays.InteractionFunctionCalls1
src/gallium/drivers/freedreno/a5xx/fd5_emit.c
+2 -2
View File
@@ -174,10 +174,10 @@ struct PACKED bcolor_entry {
uint16_t
srgb[4]; /* appears to duplicate fp16[], but clamped, used for srgb */
uint8_t __pad1[24];
uint8_t __pad1[56];
};
#define FD5_BORDER_COLOR_SIZE 0x60
#define FD5_BORDER_COLOR_SIZE 0x80
#define FD5_BORDER_COLOR_UPLOAD_SIZE \
(2 * PIPE_MAX_SAMPLERS * FD5_BORDER_COLOR_SIZE)