AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

radeonsi: assert format support in si_compute_copy_image

Browse Source 
Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16215>
This commit is contained in:
Marek Olšák
2022-04-25 05:05:59 -04:00
parent 23012ff52b
commit 54ccf24e79
1 changed files with 11 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/gallium/drivers/radeonsi/si_compute_blit.c
+11 -7
View File
@@ -538,6 +538,17 @@ void si_compute_copy_image(struct si_context *sctx, struct pipe_resource *dst, u
*/
}
/* SNORM blitting has precision issues. Use the SINT equivalent instead, which doesn't
* force DCC decompression.
*/
if (util_format_is_snorm(dst_format))
src_format = dst_format = util_format_snorm_to_sint(dst_format);
assert(ctx->screen->is_format_supported(ctx->screen, src_format, src->target, src->nr_samples,
src->nr_storage_samples, PIPE_BIND_SHADER_IMAGE));
assert(ctx->screen->is_format_supported(ctx->screen, dst_format, dst->target, dst->nr_samples,
dst->nr_storage_samples, PIPE_BIND_SHADER_IMAGE));
if (src_box->width == 0 || src_box->height == 0 || src_box->depth == 0)
return;
@@ -575,13 +586,6 @@ void si_compute_copy_image(struct si_context *sctx, struct pipe_resource *dst, u
image[1].u.tex.first_layer = 0;
image[1].u.tex.last_layer = util_max_layer(dst, dst_level);
/* SNORM blitting has precision issues on some chips. Use the SINT
* equivalent instead, which doesn't force DCC decompression.
*/
if (util_format_is_snorm(dst_format)) {
image[0].format = image[1].format = util_format_snorm_to_sint(dst_format);
}
if (is_dcc_decompress)
image[1].access |= SI_IMAGE_ACCESS_DCC_OFF;
else if (sctx->chip_class >= GFX10)