AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

winsys/amdgpu: remove return value from amdgpu_init_cs_context

Browse Source 
It can't fail.

Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/35733>
This commit is contained in:
Pierre-Eric Pelloux-Prayer
2025-06-25 11:44:01 +02:00
committed by Marge Bot
parent 613e9e9c23
commit 514a35b5ae
1 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/gallium/winsys/amdgpu/drm/amdgpu_cs.cpp
+2 -8
View File
@@ -795,7 +795,7 @@ static void amdgpu_ib_finalize(struct amdgpu_winsys *aws, struct radeon_cmdbuf *
ib->max_ib_bytes = MAX2(ib->max_ib_bytes, (rcs->prev_dw + rcs->current.cdw) * 4);
}
static bool amdgpu_init_cs_context(struct amdgpu_winsys *aws,
static void amdgpu_init_cs_context(struct amdgpu_winsys *aws,
struct amdgpu_cs_context *csc,
enum amd_ip_type ip_type)
{
@@ -817,7 +817,6 @@ static bool amdgpu_init_cs_context(struct amdgpu_winsys *aws,
csc->chunk_ib[IB_PREAMBLE].flags |= AMDGPU_IB_FLAG_PREAMBLE;
csc->last_added_bo = NULL;
return true;
}
static void cleanup_fence_list(struct amdgpu_fence_list *fences)
@@ -954,12 +953,7 @@ amdgpu_cs_create(struct radeon_cmdbuf *rcs,
memset(acs->buffer_indices_hashlist, -1, sizeof(acs->buffer_indices_hashlist));
for (unsigned i = 0; i < ARRAY_SIZE(acs->csc); i++) {
if (!amdgpu_init_cs_context(ctx->aws, &acs->csc[i], ip_type)) {
if (i)
amdgpu_destroy_cs_context(ctx->aws, &acs->csc[0]);
FREE(acs);
return false;
}
amdgpu_init_cs_context(ctx->aws, &acs->csc[i], ip_type);
/* only csc will use for buffer_indices_hashlist. */
acs->csc[i].buffer_indices_hashlist = acs->buffer_indices_hashlist;