AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

amd/vpelib: Remove checks for pitch alignment

Browse Source 
[Why]
Pitch alignment checks are inaccurate, alignment is based on elements
instead of bytes, and byte alignment is assured by addrlib. Results in
failed checks that should pass.

[How]
Remove checks.

Reviewed-by: Roy Chan <Roy.Chan@amd.com>
Acked-by: Jack Chih <chiachih@amd.com>
Signed-off-by: Brendan Leder <breleder@amd.com>
---

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/28972>
This commit is contained in:
chiachih
2024-04-27 14:43:11 +08:00
committed by Marge Bot
parent 0df1054d06
commit 5027ba64a1
1 changed files with 12 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
src/amd/vpelib/src/core/common.c
View File

@@ -321,12 +321,9 @@ enum vpe_status vpe_check_output_support(struct vpe *vpe, const struct vpe_build
}
// pitch
if ((surface_info->plane_size.surface_pitch *
vpe_get_element_size_in_bytes(surface_info->format, 0) %
vpe->caps->plane_caps.pitch_alignment) ||
((uint32_t)(surface_info->plane_size.surface_size.x +
(int32_t)surface_info->plane_size.surface_size.width) >
surface_info->plane_size.surface_pitch)) {
if ((uint32_t)(surface_info->plane_size.surface_size.x +
(int32_t)surface_info->plane_size.surface_size.width) >
surface_info->plane_size.surface_pitch) {
vpe_log("pitch alignment not supported %lu. %lu\n", surface_info->plane_size.surface_pitch,
vpe->caps->plane_caps.pitch_alignment);
return VPE_STATUS_PITCH_ALIGNMENT_NOT_SUPPORTED;
@@ -356,12 +353,9 @@ enum vpe_status vpe_check_output_support(struct vpe *vpe, const struct vpe_build
}
if (surface_info->address.type == VPE_PLN_ADDR_TYPE_VIDEO_PROGRESSIVE) {
if (((uint32_t)surface_info->plane_size.chroma_pitch *
vpe_get_element_size_in_bytes(surface_info->format, 1) %
vpe->caps->plane_caps.pitch_alignment) ||
((uint32_t)(surface_info->plane_size.chroma_size.x +
(int32_t)surface_info->plane_size.chroma_size.width) >
surface_info->plane_size.chroma_pitch)) {
if ((uint32_t)(surface_info->plane_size.chroma_size.x +
(int32_t)surface_info->plane_size.chroma_size.width) >
surface_info->plane_size.chroma_pitch) {
vpe_log("chroma pitch alignment not supported %u. %u\n",
surface_info->plane_size.chroma_pitch, vpe->caps->plane_caps.pitch_alignment);
return VPE_STATUS_PITCH_ALIGNMENT_NOT_SUPPORTED;
@@ -430,12 +424,9 @@ enum vpe_status vpe_check_input_support(struct vpe *vpe, const struct vpe_stream
}
// pitch & address
if ((surface_info->plane_size.surface_pitch *
vpe_get_element_size_in_bytes(surface_info->format, 0) %
vpe->caps->plane_caps.pitch_alignment) ||
((uint32_t)(surface_info->plane_size.surface_size.x +
(int32_t)surface_info->plane_size.surface_size.width) >
surface_info->plane_size.surface_pitch)) {
if ((uint32_t)(surface_info->plane_size.surface_size.x +
(int32_t)surface_info->plane_size.surface_size.width) >
surface_info->plane_size.surface_pitch) {
vpe_log("pitch alignment not supported %d. %d\n", surface_info->plane_size.surface_pitch,
vpe->caps->plane_caps.pitch_alignment);
@@ -451,12 +442,9 @@ enum vpe_status vpe_check_input_support(struct vpe *vpe, const struct vpe_stream
}
if (vpe_is_dual_plane_format(surface_info->format)) {
if ((surface_info->plane_size.chroma_pitch *
vpe_get_element_size_in_bytes(surface_info->format, 1) %
vpe->caps->plane_caps.pitch_alignment) ||
((uint32_t)(surface_info->plane_size.chroma_size.x +
(int32_t)surface_info->plane_size.chroma_size.width) >
surface_info->plane_size.chroma_pitch)) {
if ((uint32_t)(surface_info->plane_size.chroma_size.x +
(int32_t)surface_info->plane_size.chroma_size.width) >
surface_info->plane_size.chroma_pitch) {
vpe_log("chroma pitch alignment not supported %d. %d\n",
surface_info->plane_size.chroma_pitch, vpe->caps->plane_caps.pitch_alignment);
return VPE_STATUS_PITCH_ALIGNMENT_NOT_SUPPORTED;