AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

hk: drop soft fault assumption in hk_buffer_addr_range

Browse Source 
fixes test_index_buffer_edge_case_stream_output without soft fault.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34486>
This commit is contained in:
Alyssa Rosenzweig
2025-04-11 12:43:11 -04:00
committed by Marge Bot
parent 0f9b396588
commit 4a299bea27
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/asahi/vulkan/hk_buffer.h
+6 -5
View File
@@ -9,6 +9,7 @@
#include "hk_device_memory.h"
#include "hk_private.h"
#include "agx_abi.h"
#include "vk_buffer.h"
struct hk_device_memory;
@@ -43,12 +44,12 @@ static inline struct hk_addr_range
hk_buffer_addr_range(const struct hk_buffer *buffer, uint64_t offset,
uint64_t range, bool read_only)
{
/* If range == 0, return a NULL pointer. Thanks to soft fault, that allows
* eliding robustness2 bounds checks for index = 0, as the bottom of VA space
* is reserved.
/* If range == 0, return a pointer to the zero page. That allows
* eliding robustness2 bounds checks for index = 0, even without soft fault.
*/
if (buffer == NULL || range == 0)
return (struct hk_addr_range){.range = 0};
if (buffer == NULL || range == 0) {
return (struct hk_addr_range){.addr = AGX_ZERO_PAGE_ADDRESS, .range = 0};
}
return (struct hk_addr_range){
.addr = hk_buffer_address(buffer, offset, read_only),