AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

freedreno: Always attach bo to submit

Browse Source 
Even if app triggers undefined behaviour by using a rsc on multiple
contexts without a flush, we still should attach the bo to the batch.

Fixes: b43e5aec0d ("freedreno/batch: Move submit bo tracking to batch")
Signed-off-by: Rob Clark <robdclark@chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26162>
This commit is contained in:
Rob Clark
2023-11-12 11:08:28 -08:00
committed by Marge Bot
parent 3ca5f3bf00
commit 4807c1e173
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/gallium/drivers/freedreno/freedreno_batch.c
+4 -1
View File
@@ -549,8 +549,10 @@ fd_batch_resource_write(struct fd_batch *batch, struct fd_resource *rsc)
* ctx dependencies and let the app have the undefined behavior
* it asked for:
*/
if (track->write_batch->ctx != batch->ctx)
if (track->write_batch->ctx != batch->ctx) {
fd_ringbuffer_attach_bo(batch->draw, rsc->bo);
return;
}
flush_write_batch(rsc);
}
@@ -599,6 +601,7 @@ fd_batch_resource_read_slowpath(struct fd_batch *batch, struct fd_resource *rsc)
* by avoiding cross-ctx dependencies and let the app have the
* undefined behavior it asked for:
*/
fd_ringbuffer_attach_bo(batch->draw, rsc->bo);
return;
}