AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

nir: Move intel's half-float image store lowering to to nir_format.h.

Browse Source 
I needed the same function for v3d.  This was originally in d3e046e76c
("nir: Pull some of intel's image load/store format conversion to
nir_format.h") before we made am istake about simplifying the function.

Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
This commit is contained in:
Eric Anholt
2018-12-11 13:49:28 -08:00
parent 3a417a044e
commit 4407e688cd
2 changed files with 15 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/compiler/nir/nir_format_convert.h
+13
View File
@@ -256,6 +256,19 @@ nir_format_float_to_snorm(nir_builder *b, nir_ssa_def *f, const unsigned *bits)
return nir_f2i32(b, nir_fround_even(b, nir_fmul(b, f, factor)));
}
/* Converts a vector of floats to a vector of half-floats packed in the low 16
* bits.
*/
static inline nir_ssa_def *
nir_format_float_to_half(nir_builder *b, nir_ssa_def *f)
{
nir_ssa_def *zero = nir_imm_float(b, 0);
nir_ssa_def *f16comps[4];
for (unsigned i = 0; i < f->num_components; i++)
f16comps[i] = nir_pack_half_2x16_split(b, nir_channel(b, f, i), zero);
return nir_vec(b, f16comps, f->num_components);
}
static inline nir_ssa_def *
nir_format_linear_to_srgb(nir_builder *b, nir_ssa_def *c)
{
src/intel/compiler/brw_nir_lower_image_load_store.c
+2 -8
View File
@@ -544,14 +544,8 @@ convert_color_for_store(nir_builder *b, const struct gen_device_info *devinfo,
break;
case ISL_SFLOAT:
if (image.bits[0] == 16) {
nir_ssa_def *f16comps[4];
for (unsigned i = 0; i < image.chans; i++) {
f16comps[i] = nir_pack_half_2x16_split(b, nir_channel(b, color, i),
nir_imm_float(b, 0));
}
color = nir_vec(b, f16comps, image.chans);
}
if (image.bits[0] == 16)
color = nir_format_float_to_half(b, color);
break;
case ISL_UINT: