AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

agx: Allow larger indices for ld/st

Browse Source 
For memory load/store instructions, the immediate is 16-bit, not 8-bit
like for ALUs.

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18813>
This commit is contained in:
Alyssa Rosenzweig
2022-09-25 14:20:15 -04:00
parent 05009d1dad
commit 41b54d4a58
1 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/asahi/compiler/agx_validate.c
+10 -6
View File
@@ -99,14 +99,18 @@ agx_validate_sources(agx_instr *I)
agx_validate_assert(!src.cache);
agx_validate_assert(!src.discard);
/* Immediates are encoded as 8-bit. For integers, they extend to
* 16-bit. For floating point, they are 8-bit minifloats. The 8-bit
* minifloats are a strict subset of 16-bit standard floats, so we
* treat them as such in the IR, with an implicit f16->f32 for 32-bit
* floating point operations.
bool ldst =
(I->op == AGX_OPCODE_DEVICE_LOAD) ||
(I->op == AGX_OPCODE_UNIFORM_STORE);
/* Immediates are encoded as 8-bit (16-bit for memory load/store). For
* integers, they extend to 16-bit. For floating point, they are 8-bit
* minifloats. The 8-bit minifloats are a strict subset of 16-bit
* standard floats, so we treat them as such in the IR, with an
* implicit f16->f32 for 32-bit floating point operations.
*/
agx_validate_assert(src.size == AGX_SIZE_16);
agx_validate_assert(src.value < 0x100);
agx_validate_assert(src.value < (1 << (ldst ? 16 : 8)));
}
}