i965: Use safer pointer arithmetic in gather_oa_results()
This patch reduces the likelihood of pointer arithmetic overflow bugs in
gather_oa_results(), like the one fixed by b69c7c5dac.
I haven't yet encountered any overflow bugs in the wild along this
patch's codepath. But I get nervous when I see code patterns like this:
(void*) + (int) * (int)
I smell 32-bit overflow all over this code.
This patch retypes 'snapshot_size' to 'ptrdiff_t', which should fix any
potential overflow.
Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
Signed-off-by: Chad Versace <chad.versace@linux.intel.com>
This commit is contained in:
committed by
Chad Versace
parent
225a09790d
commit
414be86c96
@@ -907,7 +907,7 @@ gather_oa_results(struct brw_context *brw,
|
||||
return;
|
||||
}
|
||||
|
||||
const int snapshot_size = brw->perfmon.entries_per_oa_snapshot;
|
||||
const ptrdiff_t snapshot_size = brw->perfmon.entries_per_oa_snapshot;
|
||||
|
||||
/* First, add the contributions from the "head" interval:
|
||||
* (snapshot taken at BeginPerfMonitor time,
|
||||
|
||||
Reference in New Issue
Block a user