AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

etnaviv: split large multi-state updates into multiple batches

Browse Source 
A single LOAD_STATE command can only load a maximum of 1023 32bit states,
limited by the range of the count parameter in the header.
Split the state update into multiple LOAD_STATE commands if necessary.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33229>
This commit is contained in:
Lucas Stach
2025-01-28 21:55:52 +01:00
committed by Marge Bot
parent bfab2ae821
commit 3b8d0f5dd7
1 changed files with 16 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/gallium/drivers/etnaviv/etnaviv_emit.h
+16 -8
View File
@@ -73,20 +73,28 @@ etna_set_state_reloc(struct etna_cmd_stream *stream, uint32_t address,
static inline void
etna_set_state_multi(struct etna_cmd_stream *stream, uint32_t base,
uint32_t num, const uint32_t *values)
int num, const uint32_t *values)
{
if (num == 0)
return;
etna_cmd_stream_reserve(stream, 1 + num + 1); /* 1 extra for potential alignment */
etna_emit_load_state(stream, base >> 2, num, 0);
/* A single LOAD_STATE can update at most 1023 states due to the count being
* 10 bits wide in HW. Split larger updates into batches. Reserve one header
* word per batch, num words of data and one word for potential alignment */
etna_cmd_stream_reserve(stream, DIV_ROUND_UP(num, 1023) + num + 1);
for (uint32_t i = 0; i < num; i++)
etna_cmd_stream_emit(stream, values[i]);
for (; num > 0; num -= 1023, base += 4092, values += 1023) {
int batch_words = MIN2(num, 1023);
/* add potential padding */
if ((num % 2) == 0)
etna_cmd_stream_emit(stream, 0);
etna_emit_load_state(stream, base >> 2, batch_words, 0);
for (uint32_t i = 0; i < batch_words; i++)
etna_cmd_stream_emit(stream, values[i]);
/* add potential padding */
if ((batch_words % 2) == 0)
etna_cmd_stream_emit(stream, 0);
}
}
void