AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

radeonsi: do not use std::max

Browse Source 
Use MAX2 and abs to avoid build failures on some platforms.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/12434
Fixes: dc293ffe50 ("radeonsi: fallback to util_blitter_draw_rectangle")
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32959>
This commit is contained in:
Pierre-Eric Pelloux-Prayer
2025-01-09 13:36:21 +01:00
committed by Marge Bot
parent 9d4d9e6150
commit 3842d10dd7
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/gallium/drivers/radeonsi/si_state_draw.cpp
+1 -2
View File
@@ -2470,8 +2470,7 @@ static void si_draw_rectangle(struct blitter_context *blitter, void *vertex_elem
uint32_t attribute_ring_address_lo =
sctx->gfx_level >= GFX11 ? sctx->screen->attribute_pos_prim_ring->gpu_address : 0;
if (std::max(std::abs(x1), std::abs(x2)) > INT16_MAX ||
std::max(std::abs(y1), std::abs(y2)) > INT16_MAX) {
if (MAX2(abs(x1), abs(x2)) > INT16_MAX || MAX2(abs(y1), abs(y2)) > INT16_MAX) {
/* Fallback when coordinates can't fit in int16. */
util_blitter_save_vertex_elements(sctx->blitter, sctx->vertex_elements);
util_blitter_draw_rectangle(blitter, vertex_elements_cso, get_vs, x1, y1, x2, y2,