iris: Leave a comment about why Broadwell images are broken

There are a variety of ways to fix this, many of which are simple, but
I could use some advice on which ones other people prefer, and so we'll
punt until after the holidays.
This commit is contained in:
Kenneth Graunke
2018-12-31 09:19:07 -08:00
parent 7ed1383c0a
commit 307f3f9924
+4
View File
@@ -668,6 +668,10 @@ iris_setup_uniforms(const struct brw_compiler *compiler,
nir_deref_instr *deref = nir_src_as_deref(intrin->src[0]);
nir_variable *var = nir_deref_instr_get_variable(deref);
/* XXX: var->data.binding is not set properly. We need to run
* some form of gl_nir_lower_samplers_as_deref() to get it.
* This breaks tests which use more than one image.
*/
if (img_idx[var->data.binding] == -1) {
/* GL only allows arrays of arrays of images. */
assert(glsl_type_is_image(glsl_without_array(var->type)));