AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

aco/opt_postRA: remove scc == 0 for more opcodes

Browse Source 
Convert special case to s_cselect

Foz-DB Navi21:
Totals from 42 (0.05% of 79789) affected shaders:
Instrs: 91826 -> 91690 (-0.15%)
CodeSize: 496304 -> 495680 (-0.13%)
Latency: 1631974 -> 1631948 (-0.00%); split: -0.00%, +0.00%
InvThroughput: 278772 -> 278766 (-0.00%)
SALU: 10627 -> 10491 (-1.28%)

Reviewed-by: Timur Kristóf <timur.kristof@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/33734>
This commit is contained in:
Georg Lehmann
2025-02-25 11:51:14 +01:00
committed by Marge Bot
parent 83247ffa30
commit 2d68efd9f3
1 changed files with 22 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/amd/compiler/aco_optimizer_postRA.cpp
+22 -4
View File
@@ -459,14 +459,32 @@ try_optimize_scc_nocompare(pr_opt_ctx& ctx, aco_ptr<Instruction>& instr)
return;
/* Flip the meaning of the instruction to correctly use the SCC. */
if (instr->format == Format::PSEUDO_BRANCH)
if (instr->format == Format::PSEUDO_BRANCH) {
instr->opcode = instr->opcode == aco_opcode::p_cbranch_z ? aco_opcode::p_cbranch_nz
: aco_opcode::p_cbranch_z;
else if (instr->opcode == aco_opcode::s_cselect_b32 ||
instr->opcode == aco_opcode::s_cselect_b64)
} else if (instr->opcode == aco_opcode::s_cselect_b32 ||
instr->opcode == aco_opcode::s_cselect_b64) {
std::swap(instr->operands[0], instr->operands[1]);
else
} else if (instr->opcode == aco_opcode::s_cmovk_i32 ||
instr->opcode == aco_opcode::s_mul_i32) {
/* Convert to s_cselect_b32 and swap the operands. */
Instruction* cselect = create_instruction(aco_opcode::s_cselect_b32, Format::SOP2, 3, 1);
cselect->definitions[0] = instr->definitions[0];
cselect->operands[2] = instr->operands[scc_op_idx];
if (instr->opcode == aco_opcode::s_cmovk_i32) {
cselect->operands[0] = instr->operands[0];
cselect->operands[1] = Operand::c32((int32_t)(int16_t)instr->salu().imm);
} else if (instr->opcode == aco_opcode::s_mul_i32) {
cselect->operands[0] = Operand::c32(0);
cselect->operands[1] = instr->operands[!scc_op_idx];
} else {
unreachable("invalid op");
}
scc_op_idx = 2;
instr.reset(cselect);
} else {
return;
}
}
/* Use the SCC def from the original instruction, not the comparison */