gallium: refuse to create buffers larger than UINT32_MAX

pipe_resource.width0 is 32 bits and hardware support for bigger buffer is
limited (eg: AMD hardware doesn't support buffer shader resources bigger
than 4GB).

Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2053
Reviewed-by: Marek Olšák <marek.olsak@amd.com>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/2948>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/merge_requests/2948>
This commit is contained in:
Pierre-Eric Pelloux-Prayer
2019-12-05 10:07:52 +01:00
parent 0e286f6cbf
commit 2c1983aefe
@@ -289,6 +289,15 @@ bufferobj_data(struct gl_context *ctx,
struct st_memory_object *st_mem_obj = st_memory_object(memObj);
bool is_mapped = _mesa_bufferobj_mapped(obj, MAP_USER);
if (size > UINT32_MAX || offset > UINT32_MAX) {
/* pipe_resource.width0 is 32 bits only and increasing it
* to 64 bits doesn't make much sense since hw support
* for > 4GB resources is limited.
*/
st_obj->Base.Size = 0;
return GL_FALSE;
}
if (target != GL_EXTERNAL_VIRTUAL_MEMORY_BUFFER_AMD &&
size && st_obj->buffer &&
st_obj->Base.Size == size &&