AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pan/midgard: Fix shift for TLS access

Browse Source 
Due to this issue we were using 4x the memory we should have for TLS,
which was messing up the size calculations. Oops!

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
This commit is contained in:
Alyssa Rosenzweig
2019-12-07 15:54:36 -05:00
parent 05b839f354
commit 2b4da476f4
1 changed files with 18 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/panfrost/midgard/midgard_emit.c
+18 -2
View File
@@ -359,6 +359,19 @@ emit_alu_bundle(compiler_context *ctx,
}
}
/* Shift applied to the immediate used as an offset. Probably this is papering
* over some other semantic distinction else well, but it unifies things in the
* compiler so I don't mind. */
static unsigned
mir_ldst_imm_shift(midgard_load_store_op op)
{
if (OP_IS_UBO_READ(op))
return 3;
else
return 1;
}
/* After everything is scheduled, emit whole bundles at a time */
void
@@ -393,8 +406,11 @@ emit_binary_bundle(compiler_context *ctx,
unsigned offset = bundle->instructions[i]->constants[0];
if (offset) {
bundle->instructions[i]->load_store.varying_parameters |= (offset & 0x7F) << 3;
bundle->instructions[i]->load_store.address |= (offset >> 7);
unsigned shift = mir_ldst_imm_shift(bundle->instructions[i]->load_store.op);
unsigned upper_shift = 10 - shift;
bundle->instructions[i]->load_store.varying_parameters |= (offset & ((1 << upper_shift) - 1)) << shift;
bundle->instructions[i]->load_store.address |= (offset >> upper_shift);
}
}