AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

amd/vpelib: patch to match shader (#456)

Browse Source 
\[WHY\]
Shader and VPE had different behavior while adjusting the brightness

\[HOW\]
Apply the same normalization factor

\[TESTING\]
Tested on real video outputs

Co-authored-by: Tiberiu Visan <tvisan@amd.com>
Reviewed-by: Jesse Agate <Jesse.Agate@amd.com>
Reviewed-by: Krunoslav Kovac <Krunoslav.Kovac@amd.com>
Acked-by: Chenyu Chen <Chen-Yu.Chen@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32075>
This commit is contained in:
Visan, Tiberiu
2024-10-23 15:37:40 -04:00
committed by Chenyu Chen
parent 891c4694ba
commit 2172ab2c2a
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/amd/vpelib/src/core/color_cs.c
+3 -2
View File
@@ -142,7 +142,7 @@ static void color_adjustments_to_fixed_point(const struct vpe_color_adjustments
const int hw_contrast_max = 200;
const int hw_bright_min = -1000;
const int hw_bright_max = 1000;
const int hw_bright_cap = 460;
const int hw_bright_cap = 500;
int hw_val = 0;
if (icsc) {
@@ -163,7 +163,7 @@ static void color_adjustments_to_fixed_point(const struct vpe_color_adjustments
hw_val = -hw_bright_cap;
}
*grph_bright = vpe_fixpt_from_fraction(hw_val, 1000);
*grph_bright = vpe_fixpt_from_fraction(hw_val, 2550); //shader normalizes this value to the pixel range
*grph_cont = vpe_fixpt_from_fraction(
get_hw_value_from_sw_value(vpe_adjust->contrast.current, vpe_adjust->contrast.min,
@@ -622,6 +622,7 @@ static void calculate_yuv_matrix(struct vpe_color_adjustments *vpe_adjust,
for (i = 0; i < 12; i++) {
initialMatrix[i] = vpe_convfix31_32(input_cs->regval[i]); // convert from s.2.13 to s.31.32
}
color_adjustments_to_fixed_point(
vpe_adjust, ovl, &grph_cont, &grph_sat, &grph_bright, &sin_grph_hue, &cos_grph_hue);
grph_bright = vpe_fixpt_sub(grph_bright, lumaOffset);