intel: fix the gen 11 compute shader scratch IDs
Scratch space allocation is based on the number of threads in the base
configuration, and we only have one base configuration for ICL, with 8
subslices.
This fixes an issue with Aztec on Vulkan in a machine with a
configuration that's not the base. The issue looks like a regression
from b9e93db208, but it seems things are broken since forever, just
not easily reproducible.
v2: Reimplement it using the subslices variable. Don't touch TGL.
Cc: mesa-stable@lists.freedesktop.org
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4006>
This commit is contained in:
@@ -2053,9 +2053,14 @@ iris_get_scratch_space(struct iris_context *ice,
|
||||
* as well. This is not currently documented at all.
|
||||
*
|
||||
* This hack is no longer necessary on Gen11+.
|
||||
*
|
||||
* For, ICL, scratch space allocation is based on the number of threads
|
||||
* in the base configuration.
|
||||
*/
|
||||
unsigned subslice_total = screen->subslice_total;
|
||||
if (devinfo->gen < 11)
|
||||
if (devinfo->gen == 11)
|
||||
subslice_total = 8;
|
||||
else if (devinfo->gen < 11)
|
||||
subslice_total = 4 * devinfo->num_slices;
|
||||
assert(subslice_total >= screen->subslice_total);
|
||||
|
||||
|
||||
@@ -1395,7 +1395,12 @@ anv_scratch_pool_alloc(struct anv_device *device, struct anv_scratch_pool *pool,
|
||||
|
||||
const struct gen_device_info *devinfo = &device->info;
|
||||
|
||||
const unsigned subslices = MAX2(device->physical->subslice_total, 1);
|
||||
unsigned subslices = MAX2(device->physical->subslice_total, 1);
|
||||
|
||||
/* For, ICL, scratch space allocation is based on the number of threads
|
||||
* in the base configuration. */
|
||||
if (devinfo->gen == 11)
|
||||
subslices = 8;
|
||||
|
||||
unsigned scratch_ids_per_subslice;
|
||||
if (devinfo->gen >= 11) {
|
||||
|
||||
@@ -467,8 +467,13 @@ brw_alloc_stage_scratch(struct brw_context *brw,
|
||||
* brw->screen->subslice_total is the TOTAL number of subslices
|
||||
* and we wish to view that there are 4 subslices per slice
|
||||
* instead of the actual number of subslices per slice.
|
||||
*
|
||||
* For, ICL, scratch space allocation is based on the number of threads
|
||||
* in the base configuration.
|
||||
*/
|
||||
if (devinfo->gen >= 9 && devinfo->gen < 11)
|
||||
if (devinfo->gen == 11)
|
||||
subslices = 8;
|
||||
else if (devinfo->gen >= 9 && devinfo->gen < 11)
|
||||
subslices = 4 * brw->screen->devinfo.num_slices;
|
||||
|
||||
unsigned scratch_ids_per_subslice;
|
||||
|
||||
Reference in New Issue
Block a user