AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

gallium: properly type fields of pipe_resource.usage

Browse Source 
This gets rid of most of the pointless bitfields and also moves away from
unsigned, which we really should stop using :)

Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
Reviewed-by: Adam Jackson <ajax@redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/29720>
This commit is contained in:
Karol Herbst
2024-06-13 21:55:07 +02:00
committed by Marge Bot
parent 40785d9a52
commit 169dc86e74
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/gallium/include/pipe/p_state.h
+7 -7
View File
@@ -556,34 +556,34 @@ struct pipe_resource
/* Put the refcount on its own cache line to prevent "False sharing". */
EXCLUSIVE_CACHELINE(struct pipe_reference reference);
unsigned width0; /**< Used by both buffers and textures. */
uint32_t width0; /**< Used by both buffers and textures. */
uint16_t height0; /* Textures: The maximum height/depth/array_size is 16k. */
uint16_t depth0;
uint16_t array_size;
enum pipe_format format:16; /**< PIPE_FORMAT_x */
enum pipe_texture_target target:8; /**< PIPE_TEXTURE_x */
unsigned last_level:8; /**< Index of last mipmap level present/defined */
uint8_t last_level; /**< Index of last mipmap level present/defined */
/** Number of samples determining quality, driving rasterizer, shading,
* and framebuffer.
*/
unsigned nr_samples:8;
uint8_t nr_samples;
/** Multiple samples within a pixel can have the same value.
* nr_storage_samples determines how many slots for different values
* there are per pixel. Only color buffers can set this lower than
* nr_samples.
*/
unsigned nr_storage_samples:8;
uint8_t nr_storage_samples;
unsigned nr_sparse_levels:8; /**< Mipmap levels support partial resident */
uint8_t nr_sparse_levels; /**< Mipmap levels support partial resident */
unsigned compression_rate:4; /**< Fixed-rate compresion bitrate if any */
enum pipe_resource_usage usage:4;
unsigned bind; /**< bitmask of PIPE_BIND_x */
unsigned flags; /**< bitmask of PIPE_RESOURCE_FLAG_x */
uint32_t bind; /**< bitmask of PIPE_BIND_x */
uint32_t flags; /**< bitmask of PIPE_RESOURCE_FLAG_x */
/**
* For planar images, ie. YUV EGLImage external, etc, pointer to the