AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pan/midgard: Do not propagate swizzles into writeout

Browse Source 
There's no slot for it; you'll end up writing into the void and
clobbering stuff. Don't. do it.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
This commit is contained in:
Alyssa Rosenzweig
2019-08-30 14:35:01 -07:00
parent eb3cc20f42
commit 116b17d2d1
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/panfrost/midgard/midgard_opt_copy_prop.c
+5 -3
View File
@@ -53,16 +53,18 @@ midgard_opt_copy_prop(compiler_context *ctx, midgard_block *block)
if (mir_nontrivial_outmod(ins)) continue;
/* Shortened arguments (bias for textures, extra load/store
* arguments, etc.) do not get a swizzlw, only a start
* component and even that is restricted. */
* arguments, etc.) do not get a swizzle, only a start
* component and even that is restricted. Fragment writeout
* doesn't even get that much */
bool skip = false;
mir_foreach_instr_global(ctx, q) {
bool is_tex = q->type == TAG_TEXTURE_4;
bool is_ldst = q->type == TAG_LOAD_STORE_4;
bool is_writeout = q->compact_branch && q->writeout;
if (!(is_tex || is_ldst)) continue;
if (!(is_tex || is_ldst || is_writeout)) continue;
/* For textures, we get one real swizzle. For stores,
* we also get one. For loads, we get none. */