mesa: Fix bogus transform feedback error message when subscripting non-array.
Previous to this patch, if the client requested transform feedback using a subscript, but the variable was not an array (e.g. "gl_FrontColor[0]"), we would produce a bogus error message like "Transform feedback varying gl_FrontColor[0] found, but it's an array ([] expected)". Changed the error message to e.g. "Transfrorm feedback varying gl_FrontColor[0] requested, but gl_FrontColor is not an array." Reviewed-by: Kenneth Graunke <kenneth@whitecape.org> Reviewed-by: Eric Anholt <eric@anholt.net> Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
This commit is contained in:
+3
-3
@@ -1576,9 +1576,9 @@ tfeedback_decl::assign_location(struct gl_context *ctx,
|
||||
} else {
|
||||
/* Regular variable (scalar, vector, or matrix) */
|
||||
if (this->is_subscripted) {
|
||||
linker_error(prog, "Transform feedback varying %s found, "
|
||||
"but it's an array ([] expected).",
|
||||
this->orig_name);
|
||||
linker_error(prog, "Transform feedback varying %s requested, "
|
||||
"but %s is not an array.",
|
||||
this->orig_name, this->var_name);
|
||||
return false;
|
||||
}
|
||||
this->location = output_var->location;
|
||||
|
||||
Reference in New Issue
Block a user