AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

svga: Disable bogus assertions concerning min_index/max_index.

Browse Source 
min_index/max_index are merely conservative guesses, so we can't
make buffer overflow detection based on their values.

Tested-by: Jakob Bornecrantz <jakob@vmware.com>
This commit is contained in:
José Fonseca
2012-03-02 12:44:00 +00:00
parent f5d0ced242
commit 105ef87842
1 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/gallium/drivers/svga/svga_draw.c
+7 -8
View File
@@ -310,12 +310,6 @@ enum pipe_error svga_hwtnl_prim( struct svga_hwtnl *hwtnl,
assert(size);
assert(offset < size);
assert(min_index <= max_index);
if (index_bias >= 0) {
assert(offset + index_bias*stride < size);
}
if (min_index != ~0 && index_bias >= 0) {
assert(offset + (index_bias + min_index) * stride < size);
}
switch (hwtnl->cmd.vdecl[i].identity.type) {
case SVGA3D_DECLTYPE_FLOAT1:
@@ -375,9 +369,14 @@ enum pipe_error svga_hwtnl_prim( struct svga_hwtnl *hwtnl,
break;
}
if (max_index != ~0) {
assert(offset + (index_bias + max_index) * stride + width <= size);
if (index_bias >= 0) {
assert(offset + index_bias*stride + width <= size);
}
/*
* min_index/max_index are merely conservative guesses, so we can't
* make buffer overflow detection based on their values.
*/
}
assert(range->indexWidth == range->indexArray.stride);