Antonio Ospite
ddf2aa3a4d
In the C23 standard unreachable() is now a predefined function-like macro in <stddef.h> See https://android.googlesource.com/platform/bionic/+/HEAD/docs/c23.md#is-now-a-predefined-function_like-macro-in And this causes build errors when building for C23: ----------------------------------------------------------------------- In file included from ../src/util/log.h:30, from ../src/util/log.c:30: ../src/util/macros.h:123:9: warning: "unreachable" redefined 123 | #define unreachable(str) \ | ^~~~~~~~~~~ In file included from ../src/util/macros.h:31: /usr/lib/gcc/x86_64-linux-gnu/14/include/stddef.h:456:9: note: this is the location of the previous definition 456 | #define unreachable() (__builtin_unreachable ()) | ^~~~~~~~~~~ ----------------------------------------------------------------------- So don't redefine it with the same name, but use the name UNREACHABLE() to also signify it's a macro. Using a different name also makes sense because the behavior of the macro was extending the one of __builtin_unreachable() anyway, and it also had a different signature, accepting one argument, compared to the standard unreachable() with no arguments. This change improves the chances of building mesa with the C23 standard, which for instance is the default in recent AOSP versions. All the instances of the macro, including the definition, were updated with the following command line: git grep -l '[^_]unreachable(' -- "src/**" | sort | uniq | \ while read file; \ do \ sed -e 's/\([^_]\)unreachable(/\1UNREACHABLE(/g' -i "$file"; \ done && \ sed -e 's/#undef unreachable/#undef UNREACHABLE/g' -i src/intel/isl/isl_aux_info.c Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36437>
aubinator_error_decode
This tool allows decode an error state dump generated by the kernel driver.
Make a copy of the error state file (i915) :
$ sudo cp /sys/devices/pci0000:00/0000:00:02.0/drm/card0/error /tmp/error
$ sudo chmod go+rw /tmp/error
Make a copy of the error state file (Xe) :
$ sudo cp /sys/class/drm/card0/device/devcoredump/data /tmp/error
$ sudo chmod go+rw /tmp/error
Then visualize the error state (from the mesa build directory) :
$ ./src/intel/tools/aubinator_error_decode /tmp/error
intel_stub_gpu
This tool allows faking a particular device at the ioctl level. This is useful to test compiler changes (using shader-db/fossils-db replays) across a number of device you don't necessarily have access too.
Faking a DG2 device :
$ intel_stub_gpu -p dg2 fossilize-replay /path/to/fossilize.foz --enable-pipeline-stats /tmp/dg2.csv
Faking a ICL device :
$ intel_stub_gpu -p icl fossilize-replay /path/to/fossilize.foz --enable-pipeline-stats /tmp/icl.csv
intel_error2hangdump
This tool converts an error state dump into an
uncompressed/easy-to-modify binary file (format described in
src/intel/common/intel_hang_dump.h).
Capture the error state (i915) :
$ sudo cp /sys/devices/pci0000:00/0000:00:02.0/drm/card0/error /tmp/error
$ sudo chmod go+rw /tmp/error
Capture the error state (Xe) :
$ sudo cp /sys/class/drm/card0/device/devcoredump/data /tmp/error
$ sudo chmod go+rw /tmp/error
Convert an error state (from the mesa build directory) :
$ ./src/intel/tools/intel_error2hang /tmp/error
A resulting error.dmp file will be created
intel_hang_replay
This tool replays a binary file generated by intel_error2hangdump.
From the mesa build directory :
$ ./src/intel/tools/intel_hang_replay -d /tmp/error.dmp
intel_hang_viewer
This tool is a editor/visualizer for the file generated by
intel_error2hangdump. When replaying on simulation a few tweaks
might be needed in order for the simulator to accept the input
commands (this is due to divergences between the simulation & HW
implementations).
To visualize a file generated from a DG2 error state (from the mesa build directory) :
./src/intel/tools/intel_hang_viewer -p dg2 /tmp/error.dmp
To visualize and edit a file generated from a DG2 error state (from the mesa build directory) :
./src/intel/tools/intel_hang_viewer -e -p dg2 /tmp/error.dmp