Eric Anholt 8bd91d1368
util: Fix big-endian handling of z/s formats. ...
channel datatypes in Mesa are the host's endianness. For example,
PIPE_FORMAT_R32_UINT doesn't do a bswap in and out in u_format_table.c's
pack/unpack functions. So, z32_unorm shouldn't be byte swapping either,
and neither should z24s8 which is also a packed format, and once you've
got those it becomes clear that all of the swaps in this file were
mistaken.
Things would mostly work out because it's unusual to read/write Z/S data
through the GL API, and even for drivers like softpipe as long as the pack
and unpack both swap it could work anyway. However, the bug would be
visible in glReadPixels() with the matching datatype which would hit the
memcpy fastpath without doing another swap.
Caught by a mesa/main unit test on transitioning to using these
pack/unpack functions.
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com >
Reviewed-by: Adam Jackson <ajax@redhat.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10336 >
2021-04-21 19:59:10 +00:00
2021-04-21 19:59:10 +00:00
2019-11-05 16:39:55 +00:00
2021-04-19 17:59:44 +00:00
2021-04-20 17:42:21 +00:00
2021-04-19 17:59:44 +00:00
2020-08-31 09:14:57 +00:00
2019-08-08 22:02:54 +01:00
2019-09-02 12:45:45 +00:00
2021-02-24 17:11:44 +00:00
2021-04-13 05:07:42 +00:00
2019-09-19 19:56:22 +00:00
2020-03-27 21:00:09 +00:00
2020-03-20 17:25:25 +00:00
2020-09-25 20:09:08 +00:00
2020-11-26 07:58:56 +00:00
2020-12-02 19:35:59 +00:00
2021-03-19 19:33:59 +00:00
2021-03-19 19:33:59 +00:00
2020-03-27 21:00:09 +00:00
2020-11-25 09:44:11 +00:00
2021-03-16 23:37:48 +00:00
2021-03-04 04:07:46 +00:00
2021-03-04 04:07:46 +00:00
2021-02-21 02:50:45 +00:00
2019-09-17 23:39:18 +03:00
2019-09-17 23:39:18 +03:00
2021-03-01 20:52:28 +00:00
2021-04-14 08:33:14 +00:00
2020-09-01 17:45:08 +00:00
2019-10-24 16:21:01 +02:00
2020-01-14 12:00:27 +01:00
2021-03-15 03:34:48 +00:00
2021-03-15 03:34:48 +00:00
2020-08-31 09:14:57 +00:00
2020-10-06 21:07:11 -04:00
2021-02-26 18:31:19 +00:00
2021-04-07 22:57:27 +00:00
2021-04-07 22:57:27 +00:00
2020-10-19 18:41:50 +00:00
2020-12-18 01:46:00 +00:00
2020-09-28 09:14:44 -07:00
2020-09-28 09:14:44 -07:00
2021-02-18 00:27:49 +00:00
2021-03-18 01:31:31 +00:00
2021-01-08 09:37:14 +00:00
2020-10-19 03:37:42 -07:00
2021-02-21 02:50:45 +00:00
2021-02-21 02:50:45 +00:00
2021-03-15 03:34:48 +00:00
2021-03-11 23:43:47 +00:00
2021-03-11 23:43:47 +00:00
2020-04-21 11:09:03 -07:00
2020-02-24 23:07:57 +00:00
2020-04-21 11:09:03 -07:00
2020-10-27 15:33:40 -07:00
2021-04-15 16:01:21 +00:00
2020-12-02 10:12:27 -08:00
2020-07-30 10:41:00 +00:00
2020-02-04 17:33:49 +00:00
2020-11-26 07:58:56 +00:00
2020-12-01 07:11:44 +00:00
2020-11-12 11:49:12 +00:00
2020-08-21 18:22:21 +00:00
2020-05-16 12:05:37 +00:00
2020-05-16 12:05:37 +00:00
2019-09-26 20:36:41 +00:00
2019-09-26 20:36:41 +00:00
2020-05-13 23:36:44 +00:00
2020-05-13 23:36:44 +00:00
2021-01-22 17:56:08 +00:00
2020-10-20 08:33:42 +00:00
2021-04-07 22:57:27 +00:00
2021-04-07 22:57:27 +00:00
2020-11-24 21:03:34 +00:00
2020-12-01 18:03:31 +00:00
2020-11-10 15:37:07 +00:00
2021-02-18 20:59:43 +00:00
2020-10-06 21:07:03 -04:00
2020-04-18 12:18:03 +00:00
2020-03-20 15:31:10 -05:00
2020-10-27 21:05:55 +00:00
2021-01-28 18:07:09 +00:00
2021-03-29 08:31:09 +00:00
2021-03-29 08:31:09 +00:00
2020-02-24 23:07:57 +00:00
2020-08-05 18:08:06 +00:00
2020-08-13 23:18:36 +00:00
2021-01-15 20:00:20 +00:00
2020-08-05 18:08:06 +00:00
2020-08-05 18:08:06 +00:00
2020-08-05 18:08:06 +00:00
2020-11-11 06:08:15 +10:00
2020-12-03 21:19:57 +00:00
2020-08-31 09:14:57 +00:00
2020-10-06 15:59:07 +00:00
2020-09-10 09:07:11 +02:00
2021-02-26 18:31:19 +00:00
2020-11-11 09:09:45 +00:00
2020-04-21 11:09:03 -07:00
2021-02-22 00:30:46 +00:00
2020-03-27 21:00:10 +00:00
2019-12-02 13:59:28 +01:00
2020-12-29 09:07:23 +10:00
2020-12-29 09:07:23 +10:00
2021-01-09 20:51:03 -06:00
2020-03-24 08:30:34 +01:00
2021-03-02 14:37:46 +00:00
2021-01-28 18:07:09 +00:00
2021-02-19 11:05:38 +00:00
2021-03-11 04:42:15 +00:00
2020-12-10 16:48:36 +00:00
2020-05-13 23:36:44 +00:00
2020-05-13 23:36:44 +00:00
2021-04-20 00:28:35 +00:00
2020-12-14 17:28:04 +00:00
2020-10-07 21:52:04 +00:00
2020-12-01 10:04:41 +01:00
Eric Anholt
8bd91d1368