Alyssa Rosenzweig
6c0d433d19
panfrost: Centralize our model list
...
Replaces panfrost-quirks.h
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14726 >
2022-01-28 17:47:46 +00:00
Alyssa Rosenzweig
ee044d445d
panfrost: Remove NO_BLEND_PACKS quirk
...
Now unused.
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14724 >
2022-01-26 01:45:09 +00:00
Alyssa Rosenzweig
da9d6a643a
panfrost: Don't set NO_BLEND_PACKS on Bifrost
...
It doesn't make sense on Bifrost -- the only consumer of the quirk is
pan_lower_framebuffer, a Midgard-only pass.
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14724 >
2022-01-26 01:45:09 +00:00
Alyssa Rosenzweig
93f6c6586c
panfrost: Remove MIDGARD_{NO_TYPED_BLEND_STORES,MISSING_LOADS}
...
These "quirks" are common for Midgard, yet are only consumed by
pan_lower_framebuffer -- a Midgard-only pass. So the quirks should be removed
and inlined into their users. Thid removes MIDGARD_QUIRKS altogether.
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14724 >
2022-01-26 01:45:09 +00:00
Alyssa Rosenzweig
db497c27dc
panfrost: Remove NO_TILE_ENABLE_MAP quirk
...
Function of architecture. Add a comment to the sole consumer of the quirk bit
about why it's used.
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14724 >
2022-01-26 01:45:09 +00:00
Alyssa Rosenzweig
bbe0517481
panfrost: Remove MIDGARD_BROKEN_FP16 quirk
...
Unused.
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14724 >
2022-01-26 01:45:09 +00:00
Alyssa Rosenzweig
d4575bcc79
panfrost: Remove MIDGARD_SFBD quirk
...
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14724 >
2022-01-26 01:45:09 +00:00
Alyssa Rosenzweig
47a7e26954
panfrost: Remove HAS_SWIZZLES quirk
...
It's a function of the major arch.
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14724 >
2022-01-26 01:45:09 +00:00
Carsten Haitzler
b22294f6d5
panfrost: Add GPU G76 to the set of known ids
...
This is another working GPU so add the ID to the known set. Working on
real silicon and tested.
Signed-off-by: Carsten Haitzler <carsten.haitzler@foss.arm.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14517 >
2022-01-13 14:59:48 +00:00
Alyssa Rosenzweig
be5456e116
panfrost: Remove unused MIDGARD_NO_AFBC quirk
...
This is not Midgard-specific and is handled outside of the quirks
infrastructure now.
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13497 >
2021-10-22 19:33:38 -04:00
Alyssa Rosenzweig
d051b06a48
panfrost: Raise maximum texture size
...
The hardware can handle much larger textures than we allowed. The game
"Cathedral" requires larger textures for some bizarre reason. Raise the
limit so the game runs, syncing MAX_MIP_LEVELS, the comments, and the CAPs.
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com >
Closes : #5203
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12312 >
2021-08-25 13:49:17 +00:00
Alyssa Rosenzweig
6dfdeea213
panfrost: Remove unneeded quirks from T760
...
Will cause trouble later in the series when we start garbage collecting
unneeded code.
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com >
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11383 >
2021-08-23 20:54:33 +00:00
Alyssa Rosenzweig
07607c8443
panfrost: Remove unused #defines
...
Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12328 >
2021-08-11 18:00:45 +00:00
Ezequiel Garcia
ae6bc7a9d0
panfrost: Rename G52 product ID 0x7402 as G52r1
...
As pointed out by Robin Murphy, the new product ID belongs
to IP revision "G52r1".
Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10921 >
2021-05-21 19:05:07 +00:00
Ezequiel Garcia
e1959f0f59
panfrost: Add GPU IDs for G52 1-Core-2EE (RK3568/RK3566)
...
Rockchip SoCs RK3566 and RK3568 have a Gondul with
one shader core and two execution engines, with product ID 0x7402.
Quoting the datasheet:
Mali-G52 1-Core-2EE
* Support 1600Mpix/s fill rate when 800MHz clock frequency
* Support 38.4GLOPs when 800MHz clock frequency
To distinguish it from other variants of G52, we agreed
to call this "G52L", L is for Little.
Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10771 >
2021-05-12 20:45:44 +00:00
Boris Brezillon
17429b8ad4
panfrost: Pass a tile enable map to avoid reloading untouched tiles
...
We only do that when there are more than one damage rectangle and the
number of tiles to reload is significantly lower than the total number
of tiles covered by the damage extent, otherwise the overhead of the
TEM read might defeat the optimization that we might get from using one.
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10033 >
2021-04-13 18:06:37 +00:00
Boris Brezillon
4544d00e71
panfrost: Get rid of IS_BIFROST
...
Extract this information from dev->arch, and provide a helper to hide
this check.
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Reviewed-by: Italo Nicola <italonicola@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8808 >
2021-02-02 09:04:15 +01:00
Boris Brezillon
8a9b2ef82d
panfrost: Enable AFBC support on Bifrost
...
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8125 >
2021-01-04 17:05:42 +01:00
Icecream95
fdcb03c2d7
panfrost: Expose ARB_texture_filter_anisotropic on supported GPUs
...
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8149 >
2020-12-21 22:49:28 +00:00
Icecream95
48c676c501
panfrost: Add a gpu_revision argument to panfrost_get_quirks
...
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8149 >
2020-12-21 22:49:28 +00:00
Alyssa Rosenzweig
1e18d9952b
panfrost: Add MALI_EXTRACT_INDEX helper
...
Extracts the 8-bit index from a 22-bit pixel format.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Tested-by: Christian Hewitt <christianshewitt@gmail.com >
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7352 >
2020-10-31 14:09:18 +00:00
Boris Brezillon
8389976b7c
panfrost: XML-ify the blend descriptors
...
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6980 >
2020-10-07 17:54:57 +02:00
Boris Brezillon
713419eef0
panfrost: Rework fixed-function blending
...
The fixed-function blend logic uses the following equation: A + B x C.
A, B and C are configurable and can be complemented with negation (for
A and B) or inversion (for C) modifiers. Let's rework the blending
code to take that into account.
Note that we need to update the checksum of a few traces because the
equations we use have changed, leading to small deviations on the
final images. Indeed, there are several valid options for a given GL
blend equation, but the operand selection probably has an impact on the
rounding, leading to those mismatch.
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6980 >
2020-10-07 17:54:57 +02:00
Boris Brezillon
fefb3e9b70
panfrost: Add preliminary support for Mali G72
...
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Kristian H. Kristensen <hoegsberg@google.com >
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6885 >
2020-09-29 08:39:23 +00:00
Boris Brezillon
d289209ea6
panfrost: XML-ify the compute job descriptor
...
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6797 >
2020-09-21 07:35:45 -04:00
Boris Brezillon
89fafe9e92
panfrost: XML-ify the fragment job descriptor
...
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6797 >
2020-09-21 07:35:45 -04:00
Boris Brezillon
9121e7daaf
panfrost: XML-ify the write value job descriptor
...
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6797 >
2020-09-21 07:35:45 -04:00
Boris Brezillon
eb923548c5
panfrost: XML-ify the job header descriptor
...
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6797 >
2020-09-21 07:35:45 -04:00
Boris Brezillon
5d5f7552a5
panfrost: XML-ify the multi-target framebuffer descriptors
...
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6797 >
2020-09-21 07:35:45 -04:00
Boris Brezillon
efce73d99d
panfrost: XML-ify the bifrost tiler descriptors
...
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6797 >
2020-09-21 07:35:45 -04:00
Boris Brezillon
95eb7d9a34
panfrost: XML-ify the single target framebuffer descriptor
...
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6797 >
2020-09-21 07:35:45 -04:00
Boris Brezillon
e855698ddd
panfrost: XML-ify the midgard tiler descriptor
...
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6797 >
2020-09-21 07:35:45 -04:00
Boris Brezillon
3a06fc3d34
panfrost: XML-ify the local storage descriptor
...
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com >
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6797 >
2020-09-21 07:35:45 -04:00
Alyssa Rosenzweig
eb261a8018
panfrost: Remove mali_vertex_tiler_postfix
...
Now XMLified everywhere.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6476 >
2020-08-28 14:53:53 +00:00
Alyssa Rosenzweig
4467e792c5
panfrost: Inline bifrost_tiler_only
...
Pointless abstraction now that fused jobs are dropped.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6476 >
2020-08-28 14:53:53 +00:00
Alyssa Rosenzweig
0c1f44bab7
panfrost: Drop bifrost_payload_fused
...
Fused jobs are broken for various reasons almost everywhere. Drop the
reference - if for some reason somebody wants this later, it's preserved
in git.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6476 >
2020-08-28 14:53:53 +00:00
Alyssa Rosenzweig
02e768e6a9
panfrost: XMLify invocations
...
Not so bad :)
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6476 >
2020-08-28 14:53:53 +00:00
Alyssa Rosenzweig
b60d567edd
panfrost: XMLify primitive information
...
This is grouped as the latter part of the prefix. Some kludges around a
magic field for compute jobs that we'll deal with later. (I hope.)
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6476 >
2020-08-28 14:53:53 +00:00
Alyssa Rosenzweig
3cda33360e
panfrost: Drop mali_shader_meta
...
Now completely replaced by XML versions.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6440 >
2020-08-25 17:05:39 +02:00
Alyssa Rosenzweig
661b46958d
panfrost: XMLify beginning of shader descriptor
...
We have just enough abstracted now to pack this ahead-of-time, during
the CSO create, instead of at draw-time. But it's only a start.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6440 >
2020-08-25 17:05:37 +02:00
Alyssa Rosenzweig
a0857e9d9e
panfrost: Support SHADERLESS mode everywhere
...
Now that the missing bits on SFBD are identified, and we have a
reasonable way to pack the properties for Bifrost, we can probably do
this everywhere to generalize the optimization and drop the quirk.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6440 >
2020-08-25 17:05:36 +02:00
Alyssa Rosenzweig
c9858fb941
panfrost: Identify additional SFBD flags
...
These are analogues to the flags we have in the blend structure on
T760+, which enables us to fix shaderless and sRGB operation on T720.
Closes #2771
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Fixes: a64599a303 ("panfrost: Pass the sampler view format when creating a tex descriptor")
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6440 >
2020-08-25 17:05:36 +02:00
Alyssa Rosenzweig
7a95ed2ecf
panfrost: XMLify Bifrost preload
...
There's a lot of code here since the meaning of this field changes
depending on shader state. The good news is that our careful handling
allows preload registers to be decoded now, which pandecode could not
previously do. Likewise, the cmdstream code to emit this is now much
more obvious.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6440 >
2020-08-25 17:05:36 +02:00
Alyssa Rosenzweig
acf77cbb39
panfrost: XMLify bifrost1
...
It's so poorly understood there's not much to do in this commit, sadly.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6440 >
2020-08-25 17:05:36 +02:00
Alyssa Rosenzweig
1b7d4f1940
panfrost: Remove midgard1 bitfield
...
It is now entirely XML, including for decoding. Woo!
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6440 >
2020-08-25 17:05:36 +02:00
Alyssa Rosenzweig
bf6d548787
panfrost: XMLify blend equation
...
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6440 >
2020-08-25 17:05:34 +02:00
Alyssa Rosenzweig
94c9f87df1
panfrost: XMLify blend flags
...
Shared between Midgard/Bifrost. We get printing this way!
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6440 >
2020-08-25 17:05:33 +02:00
Alyssa Rosenzweig
7a13351234
panfrost: Drop union mali_attr
...
Now replaced by the XML translation. I left the comment explaining
instancing since this is still very good information about how to
calculate these fields.
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6326 >
2020-08-17 11:43:52 +00:00
Alyssa Rosenzweig
9732b64862
panfrost: Remove mali_attr_meta
...
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6326 >
2020-08-17 11:43:52 +00:00
Alyssa Rosenzweig
cdc3276317
panfrost: XMLify mali_channel
...
Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com >
Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6326 >
2020-08-17 11:43:52 +00:00