Konstantin Seurer
04abfbca57
nir: Remove gather_info after removing dead vars
...
Signed-off-by: Konstantin Seurer <konstantin.seurer@gmail.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16593 >
2022-11-11 15:17:08 +00:00
Timothy Arceri
34c52d8cb9
nir: fix typo in lower_double options handling
...
Seems the intention was to check that both flags were not enabled
instead we were checking that the floor flag was both set and not
set so the result would always be false.
Fixes: 3749a6ecd2 ("nir: honor lower_double options for ffloor and ffract")
Reviewed-by: Gert Wollny <gert.wollny@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19642 >
2022-11-11 14:36:00 +00:00
Mark Collins
d558309d67
freedreno/cffdec: Add NOP debug messages
...
We want to encode special messages into the CS that can be printed
by cffdec, these messages have identifiers that describe their
usage (message, scope begin and scope end) which allow for an
improved trace navigation experience due to the additional
information.
Signed-off-by: Mark Collins <mark@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18271 >
2022-11-11 13:50:57 +00:00
Mark Collins
d151ba5c30
tu: Implement utrace CS marker support
...
Adds support for emitting utrace markers into the CS, this allows
for useful debug information that can be decoded from a recorded
command stream.
Signed-off-by: Mark Collins <mark@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18271 >
2022-11-11 13:50:57 +00:00
Mark Collins
ac5a55ef11
common/utrace: Add CS logging support
...
Viewing CS traces retrieved from the driver is common practice to
determine driver bugs but there is no way to determine what
function a certain part of the CS was emitted by. This is crucial
information to determine what function is responsible for emitting
broken CS packets and to help with navigation of the CS trace.
Signed-off-by: Mark Collins <mark@igalia.com >
Reviewed-by: Danylo Piliaiev <dpiliaiev@igalia.com >
Reviewed-by: Yonggang Luo <luoyonggang@gmail.com >
Ack-by: Chia-I Wu <olvaffe@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18271 >
2022-11-11 13:50:57 +00:00
Mark Collins
8370a0d6bf
common/utrace: Prefix all environment variables with MESA_
...
To be more consistent with other environment variables and ensure
better scoping, all environment variables in utrace have now been
prefixed with `MESA_`.
Signed-off-by: Mark Collins <mark@igalia.com >
Reviewed-by: Danylo Piliaiev <dpiliaiev@igalia.com >
Reviewed-by: Yonggang Luo <luoyonggang@gmail.com >
Ack-by: Chia-I Wu <olvaffe@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18271 >
2022-11-11 13:50:56 +00:00
Mark Collins
086b50078d
common/utrace: Rename u_trace_context_actively_tracing to u_trace_should_process
...
Signed-off-by: Mark Collins <mark@igalia.com >
Reviewed-by: Danylo Piliaiev <dpiliaiev@igalia.com >
Reviewed-by: Yonggang Luo <luoyonggang@gmail.com >
Ack-by: Chia-I Wu <olvaffe@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18271 >
2022-11-11 13:50:56 +00:00
Mark Collins
18e820009d
common/utrace: Refactor and combine all envvars into GPU_TRACES
...
All environment variables involved in utrace usage were very
fragmented and convoluted to decode the meaning of, this commit has
simplified them down into easier to understand flags which directly
indicate the resulting behavior (such as `perfetto` enabling queued
logs rather than needing to set a `queued` flag) while combining
them into a single envvar `GPU_TRACES` and updating existing
terminology in utrace to match up with the new options.
Signed-off-by: Mark Collins <mark@igalia.com >
Reviewed-by: Danylo Piliaiev <dpiliaiev@igalia.com >
Reviewed-by: Yonggang Luo <luoyonggang@gmail.com >
Ack-by: Chia-I Wu <olvaffe@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18271 >
2022-11-11 13:50:56 +00:00
Mark Collins
044d3e53d2
tu: Move utrace arguments to start from end
...
All arguments in Turnip code are fit to be moved to the start
event where they fit better as any sequential logging should print
the arguments with the scope start as it makes more sense than
printing arguments with the end of a scope.
Signed-off-by: Mark Collins <mark@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18271 >
2022-11-11 13:50:56 +00:00
Mark Collins
e954ec7fef
tu/perfetto: Handle tracepoint args from start and end
...
Perfetto's tracing backend was designed to only handle arguments
at the end event, we want to cover arguments both at the start
and end of the trace.
Signed-off-by: Mark Collins <mark@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18271 >
2022-11-11 13:50:56 +00:00
Iago Toral Quiroga
f14e2ca099
v3dv: ignore imported BOs when tracking BO memory usage
...
Imported BOs are not allocated by the device so we don't
update BO stats when they are imported. Therefore, we should
not be updating them when they are freed either.
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19675 >
2022-11-11 13:25:28 +00:00
Jose Fonseca
6bb5aceb28
draw: Prevent index buffer overflow.
...
This prevents segfaults running wgf11draw DrawMethod=DrawIndexed tests
cases.
This change is not, however, sufficient to pass all tests. That is,
there must remain code paths where indices read beyond the end of the
index buffer do not return zero index.
Reviewed-by: Roland Scheidegger <sroland@vmware.com >
Reviewed-by: Brian Paul <brianp@vmware.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19648 >
2022-11-11 12:59:29 +00:00
Iago Toral Quiroga
2c44597181
v3dv: fix debug dump on BO free
...
We were resetting the BO struct right before dumping its data. Fix
this by moving the reset later.
Fixes: 44fa8304d4 ('v3dv: add a refcount mechanism to BOs')
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19672 >
2022-11-11 11:54:36 +00:00
Matt Coster
947e183ff5
pvr: Implement new firmware stream interface
...
Signed-off-by: Matt Coster <matt.coster@imgtec.com >
Reviewed-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com >
Reviewed-by: Frank Binns <frank.binns@imgtec.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19530 >
2022-11-11 11:34:17 +00:00
Matt Coster
a824b18fdf
pvr: Set all compute sub-command registers in the same place
...
This moves the first group of registers from
pvr_sub_cmd_compute_job_init() to just before the second group in
pvr_compute_job_ws_submit_info_init().
Signed-off-by: Matt Coster <matt.coster@imgtec.com >
Reviewed-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com >
Reviewed-by: Frank Binns <frank.binns@imgtec.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19530 >
2022-11-11 11:34:17 +00:00
noasakurajin
7666988937
disable zinks shader cache when the needed functions do not exist
...
Fixes: 4e14da056d ("zink: Enable mesa/st frontend shader caching.")
Reviewed-by: Eric Engestrom <eric@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19592 >
2022-11-11 11:16:50 +00:00
Tapani Pälli
0d85a0d7cd
anv: remove dg2 condition for Wa_22011440098
...
We need same workaround for MTL.
Signed-off-by: Tapani Pälli <tapani.palli@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19636 >
2022-11-11 10:38:24 +00:00
Tapani Pälli
3eadb3f5b0
iris: remove dg2 condition for Wa_22011440098
...
We need same workaround for MTL.
Signed-off-by: Tapani Pälli <tapani.palli@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19636 >
2022-11-11 10:38:24 +00:00
Tapani Pälli
ecd4517560
anv: setup stage bitmask for Wa_22011440098
...
Fixes: 40b66a4499 ("anv, iris: Add Wa_22011440098 for DG2")
Signed-off-by: Tapani Pälli <tapani.palli@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19636 >
2022-11-11 10:38:24 +00:00
Tapani Pälli
210d95bdb3
iris: setup stage bitmask for Wa_22011440098
...
Fixes: 40b66a4499 ("anv, iris: Add Wa_22011440098 for DG2")
Signed-off-by: Tapani Pälli <tapani.palli@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19636 >
2022-11-11 10:38:24 +00:00
Lionel Landwerlin
4ceaed7839
anv: split internal surface states from descriptors
...
On Intel HW we use the same mechanism for internal operations surfaces
as well as application surfaces (VkDescriptor).
This change splits the surface pool in 2, one part dedicated to
internal allocations, the other to application VkDescriptors.
To do so, the STATE_BASE_ADDRESS::SurfaceStateBaseAddress points to a
4Gb area, with the following layout :
- 1Gb of binding table pool
- 2Gb of internal surface states
- 1Gb of bindless surface states
That way any entry from the binding table can refer to both internal &
bindless surface states but none of the driver allocations interfere
with the allocation of the application.
Based off a change from Sviatoslav Peleshko.
v2: Allocate image view null surface state from bindless heap (Sviatoslav)
Removed debug stuff (Sviatoslav)
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7110
Cc: mesa-stable
Tested-by: Sviatoslav Peleshko <sviatoslav.peleshko@globallogic.com >
Reviewed-by: Tapani Pälli <tapani.palli@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19275 >
2022-11-11 10:13:27 +00:00
Gert Wollny
917d992b32
nir/algeraic_opt: use double options too for lowering ftrunc@64
...
ftrunc@64 also might need lowering on fp64 only, especially now
that it might be introduced by nir_lower_int64.
Fixes: 29da985682
nir/lower_int64: Enable lowering of 64-bit float to 64-bit integer conversions.
Signed-off-by: Gert Wollny <gert.wollny@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19657 >
2022-11-11 09:29:31 +00:00
Samuel Pitoiset
b142a7790e
radv: advertise extendedDynamicState3ProvokingVertexMode with NGG
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19168 >
2022-11-11 08:50:03 +00:00
Samuel Pitoiset
2cce8500de
radv: add support for dynamic provoking vertex mode with NGG
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19168 >
2022-11-11 08:50:03 +00:00
Samuel Pitoiset
d81cccbb77
radv: add lowering support for load_provoking_vtx_in_prim_amd when dynamic
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19168 >
2022-11-11 08:50:03 +00:00
Samuel Pitoiset
8d8aa05fd2
radv: declare shader arguments/locations for provoking vertex
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19168 >
2022-11-11 08:50:03 +00:00
Samuel Pitoiset
8bb572b7f8
radv: add radv_pipeline_key::dynamic_provoking_vtx_mode
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19168 >
2022-11-11 08:50:03 +00:00
Samuel Pitoiset
08b346e81a
radv: re-emit NGG culling settings when conservative rast mode is dynamic
...
Found by inspection.
Fixes: fbed3aed4a ("radv: add support for dynamic conservative rasterization mode")
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Timur Kristóf <timur.kristof@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19651 >
2022-11-11 08:20:23 +00:00
Yonggang Luo
8e677bc1e1
util: Replace the usage of boolean with c11 bool in u_cpu_detect.c
...
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19649 >
2022-11-11 06:48:46 +00:00
Yonggang Luo
e39afa1ae8
microsoft: Fixes error: unknown type name ‘boolean’ in nir_to_dxil.c
...
error message:
../../src/microsoft/compiler/nir_to_dxil.c:1711:8: error: unknown type name ‘boolean’
1711 | static boolean
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19649 >
2022-11-11 06:48:46 +00:00
Yonggang Luo
5d794e8e3d
util: Replace usage of boolean with c11 bool in src/util/format/* and src/util/tests/format/*
...
This is done by find and replace:
boolean -> bool
TRUE -> true
FALSE -> false
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19649 >
2022-11-11 06:48:46 +00:00
Yonggang Luo
d13d93b089
util: Replace the usage of boolean with c11 bool in u_debug_symbol.c
...
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19649 >
2022-11-11 06:48:46 +00:00
Yonggang Luo
28d044730f
util: Replace the usage of boolean with c11 bool in u_debug_memory.c
...
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Reviewed-by: David Heidelberg <david.heidelberg@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19649 >
2022-11-11 06:48:46 +00:00
Yonggang Luo
89f7446643
util: Replace all usage of __FUNCTION__ with __func__ in src/util/*
...
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19646 >
2022-11-11 06:15:42 +00:00
Yonggang Luo
605ebc32ee
util: Remove va_copy fixup because of c11 is required
...
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19646 >
2022-11-11 06:15:42 +00:00
Yonggang Luo
df3ca74053
util: Replace TAB with space in compiler.h
...
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19646 >
2022-11-11 06:15:42 +00:00
Yonggang Luo
6eb2512fab
util: Cleanup util/compiler.h
...
Remove MESA_*_ENDIAN
Use UTIL_ARCH_*_ENDIAN to define CPU_TO_LE32
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19646 >
2022-11-11 06:15:42 +00:00
Yonggang Luo
6e8229c45a
wsi: Use UTIL_ARCH_LITTLE_ENDIAN instead MESA_LITTLE_ENDIAN
...
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19646 >
2022-11-11 06:15:42 +00:00
Yonggang Luo
67627c84a7
meson: Fixes name_prefix for clover on mingw
...
Cc: mesa-stable
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19610 >
2022-11-11 05:38:20 +00:00
Yonggang Luo
f25d483e1b
clover: Fixes building with mingw-x86
...
Cc: mesa-stable
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19610 >
2022-11-11 05:38:20 +00:00
Yonggang Luo
a3b26e2758
clover: Rename *OpenCL.def to *OpenCL.def.in
...
Cc: mesa-stable
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19610 >
2022-11-11 05:38:19 +00:00
Yonggang Luo
f03421702c
meson: Refactoring shared gen_vs_module_defs_normal_command out
...
Cc: mesa-stable
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19610 >
2022-11-11 05:38:19 +00:00
Yonggang Luo
e5656f07c7
radv: Fixes prototypes
...
Cc: mesa-stable
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Jesse Natalie <jenatali@microsoft.com >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19610 >
2022-11-11 05:38:19 +00:00
Dave Airlie
9b3e4d5d7c
pvr: use common command buffer status
...
Reviewed-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16922 >
2022-11-11 05:01:24 +00:00
Jason Ekstrand
f1e95f324b
pvr: Hook up vk_command_buffer_ops::reset
...
Reviewed-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16922 >
2022-11-11 05:01:24 +00:00
Jason Ekstrand
255de11af3
pvr: Call command buffer reset conditionally
...
Reviewed-by: Karmjit Mahil <Karmjit.Mahil@imgtec.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16922 >
2022-11-11 05:01:24 +00:00
Dave Airlie
49c4c5cb64
turnip: use common command buffer status code.
...
Reviewed-by: Emma Anholt <emma@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16922 >
2022-11-11 05:01:24 +00:00
Jason Ekstrand
697f448f6c
turnip: Initialize push descriptors in tu_create_cmd_buffer()
...
Reviewed-by: Emma Anholt <emma@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16922 >
2022-11-11 05:01:24 +00:00
Dave Airlie
1486b54e80
panvk: move to using common command buffer status
...
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16922 >
2022-11-11 05:01:24 +00:00
Jason Ekstrand
84cd81e104
panvk: Use common code for command buffer lifecycle management
...
Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16922 >
2022-11-11 05:01:24 +00:00