Chia-I Wu
aa86369163
turnip: set ycbcr feature bits properly
...
Set ycbcr feature bits only for ycbcr formats. Besides, we can control
chroma locations only for planar formats and we support
VK_FORMAT_FEATURE_SAMPLED_IMAGE_YCBCR_CONVERSION_SEPARATE_RECONSTRUCTION_FILTER_BIT
on newer gens.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19609 >
2022-11-18 00:29:09 +00:00
Chia-I Wu
6bc1fd1862
freedreno: add has_separate_chroma_filter to fd_dev_info
...
The blob driver does not support
VK_FORMAT_FEATURE_SAMPLED_IMAGE_YCBCR_CONVERSION_SEPARATE_RECONSTRUCTION_FILTER_BIT
before a6xx_gen3. It still sets CHROMA_LINEAR bit according to
chromaFilter, but the bit has no effect before a6xx_gen3 (confirmed on
a618 with blob version 512.490.0).
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19609 >
2022-11-18 00:29:09 +00:00
Jami Kettunen
f3a9076e51
freedreno: Find curses properly for building fdperf
...
Upstream ncurses doesn't ship any legacy ncurses.pc pkg-config symlinks
(just ncursesw.pc) which Void Linux strictly follows[1] for example.
Meson (since 0.54) has a generic curses dependency which works perfectly
in this case[2], thus also bump the toplevel minimum meson version from
0.53.
[1] https://github.com/void-linux/void-packages/tree/master/srcpkgs/ncurses
[2] https://mesonbuild.com/Dependencies.html#curses
Signed-off-by: Jami Kettunen <jami.kettunen@protonmail.com >
Reviewed-by: Chia-I Wu <olvaffe@gmail.com >
Reviewed-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19664 >
2022-11-17 23:57:05 +00:00
Yonggang Luo
d1e1911d82
ci: Update dozen flakes
...
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7549
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19824 >
2022-11-17 23:42:46 +00:00
Yonggang Luo
dd34cdbfa4
svga: Fixes -Werror,-Wunused-but-set-variable for clang-15 in svga/svga_tgsi_vgpu10.c
...
error message:
../../src/gallium/drivers/svga/svga_tgsi_vgpu10.c:5199:13: error: variable 'indicesMask' set but not used [-Werror,-Wunused-but-set-variable] unsigned indicesMask = 0;
^
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Jose Fonseca <jfonseca@vmware.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19527 >
2022-11-17 23:17:40 +00:00
Yonggang Luo
e8a2f801af
softpipe: fixes -Werror,-Wunused-but-set-variable for clang-15 in sp_tile_cache.c
...
error message:
../../src/gallium/drivers/softpipe/sp_tile_cache.c:346:9: error: variable 'numCleared' set but not used [-Werror,-Wunused-but-set-variable]
uint numCleared = 0;
^
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Jose Fonseca <jfonseca@vmware.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19527 >
2022-11-17 23:17:40 +00:00
Yonggang Luo
af082cb69c
radv: fixes -Werror,-Wunused-but-set-variable for clang-15 in radv_shader_args.c
...
error message:
../../src/amd/vulkan/radv_shader_args.c:457:16: error: variable 'arg_count' set but not used [-Werror,-Wunused-but-set-variable]
unsigned arg_count = 0;
^
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19527 >
2022-11-17 23:17:40 +00:00
Yonggang Luo
4b0409ff9a
intel: fixes -Werror,-Wunused-but-set-variable for clang-15
...
one of those error message:
../../src/intel/compiler/brw_vec4_cmod_propagation.cpp:53:8: error: variable 'ip' set but not used [-Werror,-Wunused-but-set-variable]
int ip = block->end_ip + 1;
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19527 >
2022-11-17 23:17:40 +00:00
Yonggang Luo
d6bd382352
intel: Fixes -Werror,-Wbitwise-instead-of-logical for clang-15 in brw_nir_lower_shader_calls.c
...
error message:
error: use of bitwise '|' with boolean operands [-Werror,-Wbitwise-instead-of-logical]
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19527 >
2022-11-17 23:17:40 +00:00
Filip Gawin
63f353b456
r300: don't use abs twice in transform_TRUNC on older hardware
...
r400:
total instructions in shared programs: 27594 -> 27523 (-0.26%)
instructions in affected programs: 3594 -> 3523 (-1.98%)
helped: 61
HURT: 0
helped stats (abs) min: 1 max: 4 x̄: 1.16 x̃: 1
helped stats (rel) min: 1.16% max: 8.70% x̄: 2.55% x̃: 1.64%
95% mean confidence interval for instructions value: -1.29 -1.04
95% mean confidence interval for instructions %-change: -3.13% -1.97%
Instructions are helped.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19807 >
2022-11-17 21:57:38 +00:00
Jesse Natalie
efe5b9163e
meson: Enable initialized-but-unused warning for MSVC
...
Reviewed-by: Yonggang Luo <luoyonggang@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19792 >
2022-11-17 21:20:38 +00:00
Jesse Natalie
383715e33b
gallium/vl: Remove unused win32 screen var
...
Reviewed-By: Sil Vilerino <sivileri@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19792 >
2022-11-17 21:20:38 +00:00
Tomeu Vizoso
fb57aa69c8
zink/ci: Add automatic test on Adreno 618 with Turnip
...
Make the existing manual test automatic, sharding to 3 boards.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19071 >
2022-11-17 19:30:46 +00:00
Tomeu Vizoso
8aa55cbcf2
ci/freedreno: Test on a618
...
Do the same testing we currently do on a630.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19071 >
2022-11-17 19:30:46 +00:00
Tomeu Vizoso
7ba9d99e5a
ci/turnip: Shard the tests on a618 over more boards
...
12 kingoftown Chromebooks have been added to Collabora's LAVA lab.
Use them to run the same tests as before, as the jobs never take less
than 10 minutes.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19071 >
2022-11-17 19:30:46 +00:00
Konstantin Seurer
f24bb8194b
radv/rra: Fix copying accel structs that were not built yet
...
In the case that radv_GetEventStatus always returns true, the loop will
never exit.
Fixes: 5749806 ("radv: Add Radeon Raytracing Analyzer trace dumping utilities")
Reviewed-by: Friedrich Vock <friedrich.vock@gmx.de >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19772 >
2022-11-17 17:24:54 +00:00
Jason Ekstrand
a5e3a50688
vulkan: Update the XML and headers to 1.3.235
...
Acked-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19815 >
2022-11-17 16:51:05 +00:00
Sil Vilerino
0c4fdbaa92
d3d12: Video Screen - Do not crash if HEVC not supported, return no support instead
...
Fixes: 8f654b90 ("d3d12: Fix HEVC wrong caps detection due to bad parenthesis in condition")
Signed-off-by: Sil Vilerino <sivileri@microsoft.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19813 >
2022-11-17 16:02:55 +00:00
José Roberto de Souza
23adf60f96
iris: Get VM id from iris_bufmgr's fd
...
iris_bufmgr_init_global_vm() was getting the VM id from the callers
fd not the iris_bufmgr's duplicated fd.
If i915 driver decides to always return unique vm ids, like a counter
that is initialized per device. So fd0 would have vm id = 0 by
default, fd1(dup of fd0) would have vm id = 1... in this scenario it
would cause a mismatch. But it is not the current i915 implementation.
Signed-off-by: José Roberto de Souza <jose.souza@intel.com >
Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19467 >
2022-11-17 14:32:37 +00:00
Lionel Landwerlin
ac51c0c93c
intel/perf: add ACM/DG2 performance metrics
...
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Ivan Briano <ivan.briano@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18893 >
2022-11-17 12:57:07 +00:00
Lionel Landwerlin
fdf602a545
intel/perf: use the new OA format for Gfx12.5+
...
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Ivan Briano <ivan.briano@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18893 >
2022-11-17 12:57:06 +00:00
Lionel Landwerlin
61fef1ed72
intel/perf: fix B/C counters accumulation in non query mode
...
When we're not using queries, all the counters from the
MI_REPORT_PERF_COUNT are available. This is the case when using
perfetto with the global pps datasource that capture global counter
values.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Fixes: 8750f43a90 ("intel/perf: add performance query layout using MI_SRM")
Reviewed-by: Ivan Briano <ivan.briano@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18893 >
2022-11-17 12:57:06 +00:00
Lionel Landwerlin
6c2e7797f5
anv: tweak performance query timeout based on number of passes
...
This avoids device lost events when we replay a command buffer 1k
times on DG2.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Ivan Briano <ivan.briano@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18893 >
2022-11-17 12:57:06 +00:00
Lionel Landwerlin
56bd81ee21
anv/perf: fixup counter/query mapping
...
The intel_perf_counter_pass::pass field is actually useless and
invalid.
Once you have mapped all the counters to all the metrics, the order of
the metrics capture is dictated by intel_perf_get_n_passes().
When reading values that is the order we should follow.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Fixes: 2001a80d4a ("anv: Implement VK_KHR_performance_query")
Reviewed-by: Ivan Briano <ivan.briano@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18893 >
2022-11-17 12:57:06 +00:00
Lionel Landwerlin
7fbfa694a8
intel/perf: simplify pass computation loop
...
We don't need to go through all the metric sets as we're already built
a bitset matching per counter to figure out in which metric set a
particular counter is.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Ivan Briano <ivan.briano@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18893 >
2022-11-17 12:57:06 +00:00
Lionel Landwerlin
4d19685a99
intel/perf: don't ralloc on perf context a temporary hash table
...
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Ivan Briano <ivan.briano@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18893 >
2022-11-17 12:57:06 +00:00
Lionel Landwerlin
e754bf6be4
intel/perf: allocate cleared counter infos
...
This array of structure needs to be initialized to 0 as it contains a
bitset we don't explicitly clear.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Fixes: 3144bc1d33 ("intel/perf: move query_mask and location out of gen_perf_query_counter")
Reviewed-by: Ivan Briano <ivan.briano@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18893 >
2022-11-17 12:57:06 +00:00
Lionel Landwerlin
bdacd6df5a
intel/perf: add a non installable tool to print metrics
...
Useful to look at the layout of the queries.
v2: Rework based on Marcin's comment
v3: Rebase
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Ivan Briano <ivan.briano@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18893 >
2022-11-17 12:57:06 +00:00
Mark Janes
e3a842d627
intel/perf: fix overflow in index types
...
With DG2, the number of perf groups and metrics climbs into the
thousands. 16bit fields are not sufficient for storing metrics
indices, and the build throws warnings when compiling the generated
intel_perf_metrics.c
Use a 32bit integer for these values.
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Ivan Briano <ivan.briano@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18893 >
2022-11-17 12:57:06 +00:00
Lionel Landwerlin
7770346902
intel/perf: support new variable names
...
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Ivan Briano <ivan.briano@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18893 >
2022-11-17 12:57:06 +00:00
Lionel Landwerlin
c1aa1059c6
intel/perf: support new operators for upcoming metrics
...
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Ivan Briano <ivan.briano@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18893 >
2022-11-17 12:57:06 +00:00
Lionel Landwerlin
d4cbb66506
intel/perf: support more than 64 queries
...
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Ivan Briano <ivan.briano@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18893 >
2022-11-17 12:57:06 +00:00
Lionel Landwerlin
1dd4cc0da5
intel/perf: fix variable type assumption error
...
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Ivan Briano <ivan.briano@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18893 >
2022-11-17 12:57:06 +00:00
Lionel Landwerlin
440da44a84
anv: get rid of ilog2_round_up
...
__builtin_clz(value - 1) is undefined for with value=1 (because
__builtin_clz(0) is undefined).
Because we set rt_pipeline->stack_size = 1 when a ray tracing pipeline
doesn't need any stack allocation to differentiate from a dynamic size
(rt_pipeline->stack_size = 0) we can run into this undefinied behavior
issue.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Fixes: f68d64dac0 ("anv: Add support for vkCmdSetRayTracingPipelineStackSizeKHR")
Reviewed-by: Marcin Ślusarz <marcin.slusarz@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19781 >
2022-11-17 10:06:37 +00:00
Leo Liu
9bd11f6523
frontends/va: Use YUV400 YUY2 444P for JPEG only
...
Since these formats are only for JPEG, and not all the backend driver
supports these format. Eg radeonsi does, virgl doesn't, they should
be used only for JPEG profile.
Fixes d2c0ff1caf (frontends/va: add support for yuv400 and yuv444)
Signed-off-by: Leo Liu <leo.liu@amd.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19787 >
2022-11-17 09:06:15 +00:00
Samuel Pitoiset
62356e71f4
radv: suspend/resume XFB queries with NGG for meta operations
...
XFB queries enable primitives generated queries with NGG and meta
operations shouldn't be counted.
Reproduced on GFX10.3 by forcing NGG streamout.
Cc: 22.3 mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19785 >
2022-11-17 07:21:23 +00:00
Samuel Pitoiset
50fe37070f
aco: fix FS inputs loads in WQM with 16-bit
...
p_wqm needs to use the same size.
Fixes: 16d2c7ad55 ("aco/gfx11: perform FS input loads in WQM")
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19788 >
2022-11-17 07:00:02 +00:00
Alyssa Rosenzweig
b24fe2badf
asahi: Unset PIPE_CAP_POINT_SIZE_FIXED
...
We do not support glPointSize(), we need point size lowered to gl_PointSize
writes in the frontend so we can use the GLES pat.
Fixes glamor.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19606 >
2022-11-17 02:47:10 +00:00
Alyssa Rosenzweig
726603f779
asahi: Set data_valid with PERSISTENT or COHERENT
...
We won't get an unmap/flush but we could have had data already.
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19606 >
2022-11-17 02:47:10 +00:00
Asahi Lina
7522f4f714
asahi: Make resource creation code modifier-aware
...
Needed for WSI.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19606 >
2022-11-17 02:47:10 +00:00
Alyssa Rosenzweig
a57b4577a1
asahi: Fix indexed draw decode
...
Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19606 >
2022-11-17 02:47:10 +00:00
Asahi Lina
fa81da9e2f
asahi: Add render scanout to resource
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19606 >
2022-11-17 02:47:10 +00:00
Asahi Lina
2aac18d7e4
asahi: Set cfg.levels for linear framebuffers
...
Otherwise we will crash in GenXML, which does not specify a default here.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19606 >
2022-11-17 02:47:10 +00:00
Asahi Lina
a5b8918800
asahi: Set fd/ro appropriately
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19606 >
2022-11-17 02:47:10 +00:00
Asahi Lina
f1771ec398
asahi: Implement agx_resource_get_param
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19606 >
2022-11-17 02:47:10 +00:00
Asahi Lina
3732a41677
asahi: Implement agx_resource_get_handle
...
Only useful on Linux.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19606 >
2022-11-17 02:47:10 +00:00
Asahi Lina
01964625eb
asahi: Implement agx_resource_from_handle
...
Only used on Linux, but can compile anywhere.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19606 >
2022-11-17 02:47:10 +00:00
Asahi Lina
b774ed7c18
asahi: Stub import/export code
...
It will be used on Linux, and it is convenient to be able to compile the same
code on macOS in the mean time.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19606 >
2022-11-17 02:47:10 +00:00
Asahi Lina
943d939a9f
asahi: Implement dmabuf modifier queries
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19606 >
2022-11-17 02:47:10 +00:00
Asahi Lina
7147313d0a
asahi: Support XRGB formats
...
Just treat them like ARGB. Not sure if this is sane, but it works for now...
Signed-off-by: Asahi Lina <lina@asahilina.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19606 >
2022-11-17 02:47:10 +00:00