AlexIndustrial/mesa
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
182,794 Commits 1 Branch 0 Tags
ae54cbeb3f40abebb8f534c69de620d6a0ca4b2b
Commit Graph

421 Commits

Author SHA1 Message Date
Samuel Pitoiset 7ea48145a1 radv: stop clearing CMASK to 0xcc when FMASK is present on GFX9 
This is incorrect because clearing CMASK to 0xCC should only happen
for fast clears with DCC and FMASK/CMASK.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26634>
 2024-01-03 13:58:06 +00:00
David Heidelberg 9017852de4 ci/radeonsi: disable VA-API testing on raven 
Fails and freezes after Collabora farm outage.

Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26820>
 2024-01-02 21:33:51 +00:00
Konstantin Seurer b88ac6b381 nir: Optimize fpow with small constant exponents 
They would be turned into exp(log(a)*b) instead, which is slow.

Totals from 2146 (2.52% of 85071) affected shaders:
MaxWaves: 35769 -> 35779 (+0.03%); split: +0.03%, -0.01%
Instrs: 6476835 -> 6465494 (-0.18%); split: -0.18%, +0.00%
CodeSize: 35382288 -> 35347092 (-0.10%); split: -0.10%, +0.00%
SpillSGPRs: 1055 -> 1017 (-3.60%)
Latency: 75211743 -> 75063623 (-0.20%); split: -0.20%, +0.00%
InvThroughput: 17525115 -> 17501745 (-0.13%); split: -0.14%, +0.00%
VClause: 200089 -> 200077 (-0.01%); split: -0.01%, +0.01%
SClause: 293566 -> 293480 (-0.03%); split: -0.03%, +0.00%
Copies: 649631 -> 640516 (-1.40%); split: -1.44%, +0.03%
Branches: 268441 -> 268325 (-0.04%)
PreSGPRs: 146868 -> 146045 (-0.56%)
PreVGPRs: 134125 -> 134128 (+0.00%); split: -0.00%, +0.01%

Reviewed-by: Georg Lehmann <dadschoorse@gmail.com>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26727>
 2024-01-02 11:16:14 +01:00
Samuel Pitoiset 551924aa87 ci: apply two bugfixes for VKCTS 
These are needed for RADV.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26798>
 2023-12-22 20:12:39 +00:00
Eric Engestrom 91e4428dc4 radv/ci: add flake on raven 
Failed in https://gitlab.freedesktop.org/mesa/mesa/-/jobs/53017453

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26788>
 2023-12-21 13:26:21 +00:00
Samuel Pitoiset 2ce0ea8e7c radv/ci: update CI lists for NAVI10,NAVI31 and RENOIR 
These dynamic rendering failures/flakes are a known issue that will
be resolved soon as part of VKCTS. Until that, make sure CI is green.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26734>
 2023-12-20 13:06:41 +00:00
David Heidelberg 16af090908 ci/lava: separate HW definitions from SW 
Reviewed-by: Guilherme Gallo <guilherme.gallo@collabora.com>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26722>
 2023-12-20 10:15:44 +00:00
Eric Engestrom 871ea3bb88 radv/ci: add flake 
Failed in https://gitlab.freedesktop.org/mesa/mesa/-/jobs/52773139

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26704>
 2023-12-14 22:13:45 +00:00
Samuel Pitoiset 1ef5feac5e radv: fix binding partial depth/stencil views with dynamic rendering 
With dynamic rendering, it's allowed to begin rendering with depth or
stencil only but still with a depth/stencil format. The test below
checks that unbound part of ds isn't modified, if depth is bound and
stencil not and vice versa.

This fixes a recent CTS
dEQP-VK.dynamic_rendering.primary_cmd_buff.basic.partial_binding_depth_stencil.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25350>
 2023-12-14 12:54:23 +00:00
Daniel Stone 59a7fc2054 ci/radeonsi: Occlusion queries are flaky on stoney 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26678>
 2023-12-13 22:51:52 +00:00
Samuel Pitoiset ca8d9f850b radv/ci: remove dEQP-VK.mesh_shader.ext.query.* from the lists 
meshShaderQueries has been recently disabled because it causes random
GPU hangs in CI, I'm still investigating it. But let's clean the CI
lists to avoid any confusion, I will re-introduce them if needed but
this issue can also be reproduced without mesh shaders.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26651>
 2023-12-13 08:33:24 +00:00
Eric Engestrom 90a77f55de ci: drop containers, builds, and tests from post-merge pipeline 
All these jobs are redundant and a waste of resources:
- the containers have already been built & pushed in the merge pipeline
- the mesa build variants have already all passed
- the driver tests have already all passed

None of these jobs are doing anything useful in this pipeline, but it
costs a factor of 2x to our infrastructure, so let's remove them.

In other words, the only job left in the post-merge pipeline is the
`pages` job that deploys the update to the website.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26451>
 2023-12-06 08:26:04 +00:00
Eric Engestrom df8ea977be radeonsi/ci: track changes to vpelib 
According to `src/amd/meson.build`, radeonsi uses vpelib, so we should
track changes to it as well.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26479>
 2023-12-06 01:58:41 +00:00
Eric Engestrom 48324e3734 radeonsi/ci: update vangogh piglit expectations 
Looking good there, Vangogh!

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26466>
 2023-12-05 13:34:32 +00:00
Martin Roukala (né Peres) 91076fd390 amd/ci: reduce Renoir's concurrency to 16 
It seems like when we increased the number of tests per shard, we
started overcommitting the Renoir runner, leading to load averages
higher than the 16 CPU threads could handle, while also running at
75-96% memory usage.

By dropping the concurrency to 16, we should be able to reduce this
memory usage while also reducing the execution time.

Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26501>
 2023-12-05 12:45:44 +00:00
Eric Engestrom 3115e6e211 amd/ci: reuse .radeonsi-rules in .radeonsi-vaapi-rules 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26480>
 2023-12-05 06:55:21 +00:00
Eric Engestrom ebaede788e amd/ci: limit radv jobs to radv + aco files changes 
Otherwise, any change in src/amd/ would always trigger all the radv
jobs.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26460>
 2023-12-04 20:43:53 +00:00
Eric Engestrom 03d8ea9912 amd/ci: split common amd files list from radeonsi files list 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26460>
 2023-12-04 20:43:53 +00:00
Eric Engestrom 98f0800c94 amd/ci: fix yaml indentation 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26460>
 2023-12-04 20:43:53 +00:00
Eric Engestrom 2cdebf51fd amd/ci: radeonsi is gl, not vk 
Fixes: cf323446e7 ("amd/ci: run gl(es) cts & piglit on radeonsi on vangogh")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26478>
 2023-12-03 13:57:38 +00:00
Eric Engestrom 402210034b radv/ci: add navi21-aco flake 
Failed once in https://gitlab.freedesktop.org/mesa/mesa/-/jobs/52219125
but passed in the automatic retry.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26467>
 2023-12-02 09:33:46 +00:00
Samuel Pitoiset 06c9e69f44 radv/ci: add new flakes for VEGA10 
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26384>
 2023-11-28 09:04:08 +01:00
Marek Olšák 3a0a3a5c35 radeonsi: implement gl_Layer in FS as a system value 
This replaces the vec4 FS input with the Ancillary VGPR input.

Reviewed-by: Qiang Yu <yuq825@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26274>
 2023-11-24 15:37:24 +00:00
Samuel Pitoiset f39ed0063b radv/ci: add missing expected failures for mesh queries on VANGOGH 
Forgot to add them.

Fixes: b975d4e800 ("radv: enable meshShaderQueries on GFX10.3")
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26331>
 2023-11-22 08:35:54 +01:00
Samuel Pitoiset b975d4e800 radv: enable meshShaderQueries on GFX10.3 
GFX11 support will come later.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25950>
 2023-11-21 15:24:49 +00:00
Eric Engestrom 46c9128117 amd/ci: track changes to the traces config file as well 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26278>
 2023-11-20 15:23:40 +00:00
Eric Engestrom 4de3ce1f2c ci/piglit: specify only the traces file in the job config 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26278>
 2023-11-20 15:23:40 +00:00
Eric Engestrom 1b18ca83fa amd/ci: avoid re-running all the test jobs when changing the expectations for only one of them 
Previously, any change to any job would trigger every job.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26127>
 2023-11-17 14:22:46 +00:00
Eric Engestrom fdbb5d5898 ci/valve-infra: ensure the correct farm picks up the job 
Until now, any farm that has a DUT that matches could have picked up the
job.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25821>
 2023-11-14 10:25:24 +00:00
Samuel Pitoiset dfc125d423 radv: fix VRS subpass attachment when HTILE can't be enabled on GFX10.3 
On GFX10.3, VRS rates need to be copied to the HTILE buffer but in some
situations, like for mips, it's not always possible to enable HTILE.
In this case, we can fallback to our internal HTILE buffer and tweak
the depth/stencil registers to use this HTILE buffer.

This fixes a bunch of VRS crashes on GFX10.3.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26025>
 2023-11-14 09:02:46 +00:00
Friedrich Vock 61203f6078 radv/ci: Update skips comments 
dEQP-VK.api.device_init.create_instance_device_intentional_alloc_fail.basic
doesn't fail anymore, but it takes nearly 5 minutes to run, so keep
skipping it.

Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Reviewed-by: Faith Ekstrand <faith.ekstrand@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26164>
 2023-11-13 20:09:31 +00:00
Marek Olšák 9579503bef radeonsi: adjust the total viewport area 
I think these are the correct numbers.

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25941>
 2023-11-10 18:03:57 -05:00
Martin Roukala (né Peres) 781e1a34cf radv/ci: fix vkcts-navi21-valve execution 
Fixes: 5e44cee47d ("ci: inject gfx-ci/linux S3 artifacts without rebuilding containers")
Suggested-by: David Heidelberg <david.heidelberg@collabora.com>
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26134>
 2023-11-10 04:37:56 +00:00
Eric Engestrom 37c7ffb958 radv/ci: add polaris10 flakes 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26135>
 2023-11-09 20:59:36 +00:00
Eric Engestrom 3af19432e9 radv/ci: add vega10 flakes 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26135>
 2023-11-09 20:59:36 +00:00
Eric Engestrom d42d2ee3a5 radv/ci: add navi21 flakes 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26135>
 2023-11-09 20:59:36 +00:00
Eric Engestrom b6dbbd3ff7 radeonsi/ci: document new failures and flakes 
These seem to have appeared between cd0a01522f and 106acbbed9

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26126>
 2023-11-09 11:14:14 +00:00
Samuel Pitoiset c2e6569b46 ci: re-apply two mesh/task query fixes for VKCTS 
These are needed by RADV to enable mesh/task shader queries.

My last attempt was broken, for obscur reasons I used invalid hashes
and the dEQP build script didn't reject them. Hopefully now it should
fail if a hash is invalid.

The dEQP list changes introduced even more failures with some drivers.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26079>
 2023-11-08 07:02:27 +00:00
Marek Olšák ca1d37e1db radeonsi: adjust setting PA_SC_EDGERULE once more 
based on PAL.

Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26055>
 2023-11-05 14:06:52 -05:00
Eric Engestrom 47398c65ee ci/radeonsi: add another flake 
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26020>
 2023-11-03 09:20:32 +00:00
Samuel Pitoiset fc9bab73a9 radv/ci: document one more flake test 
This test consistently fails on some GPUs (already documented) but on
some others it's a flake. It's a known issue that should be fixed soon
in RADV.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/26019>
 2023-11-03 09:16:54 +01:00
Samuel Pitoiset 024dab650e radv/ci: enable RADV_DEBUG=nomeshshader for vkcts-navi31-valve 
To make VKCTS on NAVI31 stable until the task shader issue is
resolved.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25969>
 2023-11-01 08:50:06 +01:00
Samuel Pitoiset 15f92c3b2c radv/ci: update list of expected failures/flakes for NAVI31 
Let's clean the flakes list, it might be needed to re-add some of them
but we will track those.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25969>
 2023-11-01 08:49:35 +01:00
Samuel Pitoiset 7d96fe853e radv: fix a synchronization issue with primitives generated query on RDNA1-2 
Only RDNA1-2 are affected because RADV needs to handle the legacy vs
NGG path for this query, and the NGG results are stored with 2 extra
64-bit values.

Fixes flakes with
dEQP-VK.transform_feedback.primitives_generated_query.* since VKCTS
1.3.7.0.

Cc: mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25862>
 2023-10-30 07:33:06 +00:00
Samuel Pitoiset ef0997baf1 ci: update CTS to vulkan-cts-1.3.7.0 
This contains many new tests, especially shader object tests.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25476>
 2023-10-18 12:52:37 +00:00
Martin Roukala (né Peres) f5cf90fbea radv/ci: tighten the vkcts-navi21 timeouts 
The jobs should never take longer than 30 minutes, so let's enforce it!

Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25704>
 2023-10-13 15:59:18 +00:00
Emma Anholt 534511935d ci/radeonsi: Drop an xfail for vangogh. 
It's passed in the last 3 nightly runs.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25693>
 2023-10-13 01:12:59 +00:00
Samuel Pitoiset 7397502a1f radv: disable primitive restart for non-indexed draws on GFX11 
Primitive restart is also applied to non-indexed draws on AMD GPUs. On
GFX11, DISABLE_FOR_AUTO_INDEX can be set but we will need a different
solution for older GPUs.

This fixes all line related flakes in CI (at least).

Cc: mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25639>
 2023-10-12 06:33:40 +00:00
Samuel Pitoiset 70de5d098b radv/ci: update list of flakes for STONEY 
These should have been fixed couple of weeks ago.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25656>
 2023-10-11 15:39:11 +00:00
Samuel Pitoiset 129d58e813 radv/ci: update list of flakes for VANGOGH 
This one is already skipped in radv-skips.txt.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25656>
 2023-10-11 15:39:11 +00:00