a42f8d49c3
radv: use LATE_Z for depth/stencil attachments used in feedback loops
...
To make sure shader invocations read the correct values.
Fixes dEQP-VK.rasterization.rasterization_order_attachment_access.*.samples_*.multi_draw_barriers
Cc: 22.3 mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19728 >
2022-12-06 10:34:11 +01:00
f7e76eee28
ci/amd: re-enable previously OOM tests
...
Since we have ZRAM now, we can enable previously failing tests on OOM.
Reviewed-by: Marek Olšák <marek.olsak@amd.com >
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19535 >
2022-12-02 13:51:15 +00:00
921cfcf4c4
ci: Rebalance radv/grunt testing
...
We've recently rebalanced our lab devices to get a fewer number of
grunts. Switch to scheduling only on the newer shinier ones, running
fewer tests. We'll evaluate the runtime, and if they're quick enough
then we can increase the amount of testing we do.
Signed-off-by: Daniel Stone <daniels@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20081 >
2022-11-30 23:58:14 +00:00
df0842c4f2
Revert "radeonsi/ci: update stoney fail -> flakes"
...
This is partial reverts commit 5ed2265fbfluoyonggang@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19860 >
2022-11-30 17:24:03 +00:00
73f1fa4354
ci: Update radeonsi-raven xfail to flake
...
Partial revert "ci/amd: add raven flakes which was previously failing"
This reverts commit fbf93ef821luoyonggang@gmail.com >
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7738
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19860 >
2022-11-30 17:24:03 +00:00
fbf93ef821
ci/amd: add raven flakes which was previously failing
...
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20022 >
2022-11-26 23:35:53 +01:00
0cee008fee
Revert "glx: Fix drawable refcounting for naked Windows"
...
This reverts commit 768238fdc0Fixes : #7674 , #7435
Acked-by: Michel Dänzer <mdaenzer@redhat.com >
Acked-by: Tapani Pälli <tapani.palli@intel.com >
Acked-by: Adam Jackson <ajax@redhat.com >
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19972 >
2022-11-25 20:08:45 +00:00
8d83ffe531
radv/ci: Add coverage for ETC2 emulation.
...
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19914 >
2022-11-25 17:16:14 +00:00
e3506dd06f
radv/ci: don't download back the vkd3d-proton.cache files
...
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19930 >
2022-11-24 06:54:44 +00:00
909fa621c4
radv/ci: set B2C_JOB_VOLUME_EXCLUSIONS in all jobs
...
This will also speed up the execution time of non-vkcts jobs.
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19930 >
2022-11-24 06:54:44 +00:00
bd743d7db5
radv/ci: do not sync back the install folder
...
When a job is over, we download back all the files generated by the
job. This however includes the mesa install/ folder which is close
to 1G in size.
This commit adds the install/ folder to the exclusion list for the
volume mirroring.
Reviewed-by: Daniel Stone <daniels@collabora.com >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19930 >
2022-11-24 06:54:44 +00:00
9eccb54dbf
radv/ci: make use of the new VanGogh runners
...
I just added 3 new Steam Decks at my home CI, bringing the total count
to 5. Let's make use of 2 of these to reduce execution time in Mesa CI
and leave the last one available for DXVK-CI.
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19929 >
2022-11-23 07:20:47 +00:00
5ed2265fbf
radeonsi/ci: update stoney fail -> flakes
...
Reviewed-by: Emma Anholt <emma@anholt.net >
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19941 >
2022-11-23 01:45:37 +01:00
165ef452fd
radv/ci: add one more pipeline barrier test as flake
...
With the new memory type, this test timeout most of the time but it
always pass.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19808 >
2022-11-21 07:55:24 +01:00
4f74621884
ci/amd: drop glmark2 traces, useless
...
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19838 >
2022-11-18 14:42:32 +00:00
6e3fc88f0c
radv/ci: mark the whole texturequerylod subtests as flakes on renoir
...
Seems like we keep on getting more of these flakes, so let's be a bit
broader.
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19742 >
2022-11-16 12:20:29 +00:00
54f5cfe81b
radv/ci: enable pre-merge testing for vkcts on navi21
...
It has been a long-time coming, hasn't it? Hopefully more will come
soon!
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19556 >
2022-11-10 13:22:33 +00:00
5e7cb59e11
radv/ci: move manual job decision to the jobs
...
This enables selectively enabling pre-merge testing on a per-job basis.
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19556 >
2022-11-10 13:22:33 +00:00
078020c45e
ci: introduce the VALVE_FARM variable
...
This mirrors all the other *_FARM variables, and allows developers to
quickly disable all the jobs that would otherwise run on Valve's CI
infrastructure by setting it to the 'offline' value.
To this end, .radv_rules gets split into .radv-collabora-rules and
.radv-valve-rules, since the driver will be testable in two different
test farms. Every radv job is then made to inherit from the right farm.
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19556 >
2022-11-10 13:22:33 +00:00
560b327696
radv/ci: add more subtests to VanGogh's flakes list
...
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19591 >
2022-11-09 12:18:04 +00:00
af868fcaad
radv/ci: add another test to the navi21 flakes list
...
Add dEQP-VK.memory.pipeline_barrier.host_read_host_write.1048576 to
the list of flakes of navi21. Found after 80 runs.
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19569 >
2022-11-07 15:31:13 +00:00
c1c7adbcbd
radv/ci: use wildcards for the query_pool.statistics_query flakes on VG
...
I got yet another new failure in VanGogh, and rather than playing the
game of wack a mole, let's be a little less picky and just use these
wildcards:
- dEQP-VK.query_pool.statistics_query.geometry_shader_primitives.*
- dEQP-VK.query_pool.statistics_query.host_query_reset.geometry_shader_primitives.*
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19541 >
2022-11-07 10:01:52 +00:00
7c5c181694
ci: Uprev kernel to 6.0
...
And also enable some kconfigs needed by existing Qualcomm-based
Chromebooks and also a new model: kingoftown.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19069 >
2022-11-04 14:51:24 +00:00
67cee534a8
CI: convert to use the new S3 server instead of the legacy minio
...
We don't need to login anymore, but we can't use plain minio commands
now. `ci-fairy` got a helper as `s3cp` to keep an almost identical
API.
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19076 >
2022-11-04 11:41:42 +00:00
dd908e87d0
radv/ci: document a recent regression on VanGogh
...
It seems like !19442 may have been introducing a lot of flakes in the
dEQP-VK.query_pool.statistics_query.* tests.
Samuel is looking into it right now, but let's document the flakes in
the mean time so that we can get back to a green baseline.
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Acked-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19470 >
2022-11-03 12:01:26 +00:00
751eb1ba06
radv/ci: document a flake on VanGogh
...
Seen only once, so not really worth filing a bug for.
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Acked-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19470 >
2022-11-03 12:01:26 +00:00
a7ad99f0ae
radv/ci: document some VanGogh flakes that came from splitting the job
...
These tests are also flaky on NAVI21, which were also introduced when
the job was split in two.
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Acked-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19470 >
2022-11-03 12:01:26 +00:00
6fd1414016
radeonsi/ci: Test piglit quick_shader profile as well
...
It's useful for catching regressions, e.g. it would have caught
https://gitlab.freedesktop.org/mesa/mesa/-/issues/7567 .
For the radeonsi-stoney-gl:amd64 job, we can use the "gpu" profile,
which contains quick_gl and quick_shader.
For the radeonsi-raven-piglit-gl:amd64 job, that would almost double
the runtime, and bring it dangerously close to the 30 minutes timeout.
Instead, split it up into radeonsi-raven-piglit-quick_gl:amd64 and
radeonsi-raven-piglit-quick_shader:amd64 jobs.
v2:
* Rebase, drop spec@arb_tessellation_shader@execution flakes and add
one crash instead.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19378 >
2022-10-31 16:58:26 +00:00
c23727d554
radeonsi,radv/ci: Increase coverage
...
12 more machines with Stoney Ridge have been added to Collabora's lab.
Use the new ones for testing more of RadeonSI, and repurpose the freed
ones for more RADV coverage.
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19161 >
2022-10-20 08:03:05 +00:00
c38111f6b4
radv/ci: run two jobs in parallel to reduce the execution time
...
This should bring the overall execution time at around 15 minutes \o/,
but it exposes more issues in the driver:
- [...].linear_interpolation.no_offset_8_samples (#7220 )
- Timeouts on some dedicated_alloc.image.full.1048577.* tests
- Timeout on memory.pipeline_barrier.host_read_host_write
More performance improvements should come later, as the load average
remains in the [12, 16] range when running on my machine on a navi22
gets me a 31 load average and a lower execution time by a couple of
minutes.
References: #7220
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19111 >
2022-10-20 09:33:53 +03:00
2459fcd9ff
radv/ci: bump the job count on navi21
...
We got shiny new hosts for our navi21 which sport twice as many cores
as the previous hosts. Let's try to keep them fed!
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19111 >
2022-10-20 09:33:53 +03:00
ebf7f7a182
aco/spill: Fix spilling of Phi operands
...
By adding the renamed variable, phi operands got spilled twice at the precessors.
Fixes: dEQP-VK.ray_query.misc.dynamic_indexing
Closes : #7493
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19109 >
2022-10-17 19:50:32 +00:00
6558ecf3eb
radv: Mark dEQP-VK.ray_query.misc.dynamic_indexing as crashing in CI.
...
Gitlab: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7493
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19073 >
2022-10-14 21:34:54 +00:00
a1d34d8c95
ci/amd: move radeonsi in amd directory
...
Deduplicate jobs, make easier to use GL+VK scenarios.
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17938 >
2022-09-27 11:59:28 +00:00
eded5bda4e
radv/ci: add piglit testing with Zink on NAVI10
...
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18315 >
2022-09-23 11:15:16 +02:00
2aa4ed16e2
radv/ci: move some tests from the renoir fail to its flake list
...
This mirrors the change we made for vega10 (6bbe3c6d3martin.roukala@mupuf.org >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18590 >
2022-09-15 14:12:07 +00:00
efd8d0f6e7
radv/ci: cleanup lists of failures/flakes
...
When tests are already in the flakes list, it's useless to mark them
as expected failures.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18592 >
2022-09-15 07:49:33 +02:00
0ee5217fdd
radv/ci: re-enable dEQP-VK.renderpass2.depth_stencil_resolve.*_samplemask
...
Since RADV switched to 100% dynamic rendering, image transitions for
attachments not used in a subpass are correctly performed.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18542 >
2022-09-13 06:39:50 +00:00
441598eca6
radv: Switch to dynamic rendering only
...
Also, update list of expected failures.
dEQP-VK.image.sample_texture.*_bit_compressed_format_two_samplers_*
now reliably pass on Polaris10 (GFX8) and Pitcairn (GFX6).
Stoney has new failures but given there is already a lot of
depth/stencil resolve failures, we shouldn't worry about them.
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15587 >
2022-09-09 09:24:59 +00:00
bbb3749077
radv/ci: document an unstable test
...
The test seem to fail when run in conjunction with other tests. This
got revealed after I introduced parrallelism in the VKCTS execution on
VanGogh.
This was caught by pre-merge CI, but idiot me thought this was a
flake... and did not try re-running the job to verify...</BrownBag>
Reference: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7220
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18480 >
2022-09-09 08:38:10 +00:00
daafeb9893
radv/ci: run vkcts on the two steam decks in parallel
...
We just added a new Steam Deck to our CI, which should allow us to
halve the execution time of a full VKCTS run from 1h20 to a more
reasonable 40 minutes.
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18432 >
2022-09-07 08:37:59 +00:00
4f11fba0c1
radv: Enable EXT_mesh_shader on RDNA2 with RADV_PERFTEST=ext_ms
...
Signed-off-by: Timur Kristóf <timur.kristof@gmail.com >
Reviewed-by: Rhys Perry <pendingchaos02@gmail.com >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Acked-by: Martin Roukala <martin.roukala@mupuf.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18367 >
2022-09-05 13:09:29 +00:00
703d66254d
radv/ci: disable kabini's vkd3d job
...
The vkd3d update increased its RAM usage above the 4GB of RAM the
kabini has... which leads to amdgpu complaining about not having
enough RAM for command submission.
Let's disable the job until we find a way to lower concurrency or
increase the amount of carveout that could be used for command
submission.
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18346 >
2022-09-01 10:13:05 +00:00
2e39f41c23
radv/ci: disable the POLARIS10 jobs
...
A kernel bug makes the first-context's creation likely to hang the GPU,
which most times than not end up failing the job despite multiple
retries.
Disable the jobs until the bug gets bisected or worked around
effectively.
Signed-off-by: Martin Roukala (né Peres) <martin.roukala@mupuf.org >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18346 >
2022-09-01 10:13:05 +00:00
a82b9d6001
aco: Fix image instructions with lod when 2d_view_of_3d is enabled on GFX9.
...
If there's a lod parameter it matter if the image is 3d or 2d because
the hw reads either the fourth or third component as lod. So detect
3d images and place the lod at the third component otherwise.
Signed-off-by: Georg Lehmann <dadschoorse@gmail.com >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18114 >
2022-08-31 17:44:38 +00:00
3c63ef0c98
radv/llvm: fix packed VS inputs on GFX6/GFX10+
...
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18225 >
2022-08-26 15:28:55 +00:00
4e52efcc43
radv: Use VK_IMAGE_LAYOUT_ATTACHMENT_FEEDBACK_LOOP_OPTIMAL_EXT for render loops
...
This commit fixes
dEQP-VK.rasterization.rasterization_order_attachment_access.format on
GFX9 because changing the layout for Vulkan feedback loops will trigger
a fast-clear eliminate. Though, the root cause is unrelated to that and
it's because the CMASK/FMASK initialization on GFX9 is currently broken
for TC-compatible images (there is a TODO somewhere).
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18084 >
2022-08-23 16:41:56 +00:00
995480a3f7
radv/ci: Remove host build related fails
...
!17028 removed acceleration structure host build support.
Signed-off-by: Konstantin Seurer <konstantin.seurer@gmail.com >
Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18142 >
2022-08-20 17:48:04 +00:00
93fa687808
radv: do not compress DCC in presence of render loops on GFX10+
...
DCC shouldn't be compressed for Vulkan feedback loops (ie. render pass
with input attachments). It looks like it has always been broken...
Note that GFX9 and earlier chips aren't affected because they don't
compress DCC on GENERAL.
This fixes
dEQP-VK.rasterization.rasterization_order_attachment_access.format*.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com >
Reviewed-by: Joshua Ashton <joshua@froggi.es >
Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18104 >
2022-08-17 22:43:39 +02:00
37dfa4e3f3
radv: fix cleaning the meta query state if an error occured
...
It's already correctly cleaned in radv_device_init_meta().
This fixes a recent regression with
dEQP-VK.api.device_init.create_instance_device_intentional_alloc_fail.
Fixes: 1a95d43e55samuel.pitoiset@gmail.com >
Reviewed-by: Konstantin Seurer <konstantin.seurer@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17952 >
2022-08-10 07:21:46 +00:00
Samuel Pitoiset