Lionel Landwerlin
94bb4a13fa
intel/fs: make Wa_1806565034 conditional to non robust access
...
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Ivan Briano <ivan.briano@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20280 >
2022-12-13 18:05:19 +00:00
Iván Briano
68b546ec3d
hasvk: pipelineStageCreationFeedbackCount is allowed to be 0
...
Fixes: 6601e5d6fc ("anv: implement VK_EXT_pipeline_creation_feedback")
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20216 >
2022-12-12 22:32:42 +00:00
Rebecca Mckeever
aa76b70751
hasvk: Delete VK_KHR_device_group provided entrypoints
...
Delete anv_CmdDispatch, anv_CmdSetDeviceMask, and
anv_GetDeviceGroupPeerMemoryFeatures so that the vk_common_*
versions will be used instead. This will avoid repeated code.
Signed-off-by: Rebecca Mckeever <rebecca.mckeever@collabora.com >
Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20218 >
2022-12-09 14:07:59 -06:00
Kenneth Graunke
88918baf5c
intel/compiler: Delete key->msaa_16
...
None of the drivers have used this since we dropped i965, and BLORP
no longer uses it as of the previous commit. We can also drop the
former compressed_multisample_tex_mask (now padding) field so that
things remain 64-bit aligned.
Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20223 >
2022-12-09 10:18:25 +00:00
Kenneth Graunke
584e18863e
intel: Drop compressed_multisample_layout_mask from the compiler keys
...
The compiler looks at this key field to determine whether to perform
an MCS fetch for a txf_ms or samples_identical texture message, if a
nir_tex_src_ms_mcs_intel source wasn't provided. If it isn't set,
it instead uses constant 0 (nothing is compressed).
All of the drivers (iris, crocus, anv, hasvk) unconditionally set this
to ~0 because we don't want to pay for costly shader recompiles (which
can cause nasty stuttering). Most textures are compressed anyway, and
the hardware ignores the l2dms MCS parameter if MCS is disabled.
The only user was BLORP, which sets the key field based on whether the
texture's aux usage has MCS. But if it has MCS, it also does the MCS
fetch itself and supplies it directly. Otherwise, it relies on the
compiler to fill in the 0 value. But it could easily just provide the
0 value itself in that case and not rely on the compiler at all.
With that fixed, we can just drop the key fields entirely. We leave
them as padding for now to avoid repacking structures; we won't need
to after the next commits anyway.
Reviewed-by: Jason Ekstrand <jason.ekstrand@collabora.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20223 >
2022-12-09 10:18:25 +00:00
Väinö Mäkelä
d4bcfed422
hasvk: Allow aliasing with modifiers for WSI images
...
Ignore ALIAS_BIT when format comes from WSI because
we have the ability to bind the MEMORY_BINDING_PRIVATE
from the other WSI image.
This commit is the same as f350b78b but for hasvk.
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19840 >
2022-12-09 08:35:02 +00:00
Jordan Justen
0d9be82fe6
intel/genxml: Add genX_rt_pack.h
...
Signed-off-by: Jordan Justen <jordan.l.justen@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20225 >
2022-12-09 01:43:39 +00:00
Väinö Mäkelä
4035853523
hasvk: Report correct multisampling limits on gfx7
...
Some limits reported by hasvk were too high, which caused CTS tests to
fail.
Reviewed-by: Emma Anholt <emma@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19393 >
2022-12-08 00:16:44 +00:00
Otavio Pontes
2e775b8bdb
anv/hasvk: Clamping Scissor Rect values in a valid range
...
On cmd_buffer_emit_scissor(), if VkViewport height or width are set to
a value lower than 1.0, y_max or x_max can be attributed negative values,
causing an overflow. That leads to ScissorRectangleYMax or
ScissorRectangleXMax to be set to values on an unsupported range.
Clamping x_max and y_max in the valid range solves the problem.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7471
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20200 >
2022-12-07 12:19:42 +00:00
Lionel Landwerlin
b9403b1c47
intel: factor out dispatch PS enabling logic
...
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Ivan Briano <ivan.briano@intel.com >
Tested-by: Mark Janes <markjanes@swizzler.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20169 >
2022-12-06 00:37:47 +02:00
Lionel Landwerlin
8baacba4d6
hasvk: remove coarse pixel checks
...
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Reviewed-by: Caio Oliveira <caio.oliveira@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19852 >
2022-12-02 09:18:17 +00:00
Jason Ekstrand
2d150f3ecd
hasvk: Drop more DG2 code
...
v2: remove unused devinfo (Lionel)
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19852 >
2022-12-02 09:18:17 +00:00
Jason Ekstrand
d0fea83d7b
hasvk: Rip out local memory support
...
Things could probably be simplified further but this at least gets rid
of most of the dead code and the dead flags and fields.
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19852 >
2022-12-02 09:18:17 +00:00
Jason Ekstrand
4256d2cbc2
hasvk: Rip out scratch surfaces
...
These are a DG2+ thing
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19852 >
2022-12-02 09:18:17 +00:00
Jason Ekstrand
eea49c7d32
hasvk: Drop SKL+ features
...
Most of these have already had all the code removeed. We just need to
remove the feature bits and queries.
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19852 >
2022-12-02 09:18:17 +00:00
Jason Ekstrand
b71ac720a8
hasvk: Drop support for atomic_int64 and atomic_float2
...
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19852 >
2022-12-02 09:18:17 +00:00
Jason Ekstrand
49201fe8c1
hasvk: Drop bindless image support
...
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19852 >
2022-12-02 09:18:17 +00:00
Jason Ekstrand
7b700369b1
hasvk: Drop A64 descriptor set support
...
It's only used by task/mesh and ray-tracing. Also drop a couple
remaining ray query things and a task/mesh we left behind.
v2: Fix incorrect use of nir_load_desc_set_address_intel (Lionel)
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19852 >
2022-12-02 09:18:17 +00:00
Jason Ekstrand
85cfa21e04
hasvk: Drop remnants of ray queries
...
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19852 >
2022-12-02 09:18:17 +00:00
Jason Ekstrand
e490434479
hasvk: Drop CCS_E support
...
Oh, for the days of Broadwell and earlier where compression was called
fast-clear. That was a simpler time. The birds sang in the trees, the
oceans weren't brown from oil spills, and Intel surface compression was
actually comprehendable by humans. To help the reviewer, keep the
following in mind:
1. CCS_E is SKL+
2. Implicit CCS is TGL+
3. The AUX TT (AKA aux map) is TGL+
4. HIZ+CCS, stencil CCS, and CCS for storage images are all TGL+
4. CCS_D surfaces only ever get full resolves and MCS surfaces only
ever get partial resolves
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19852 >
2022-12-02 09:18:17 +00:00
Jason Ekstrand
5f1dbd80b3
hasvk: Rip out primitive replication
...
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19852 >
2022-12-02 09:18:17 +00:00
Jason Ekstrand
7f97cd04c9
hasvk: Rip out remaining traces of CPS/FSR
...
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19852 >
2022-12-02 09:18:17 +00:00
Jason Ekstrand
90aab6e9a5
hasvk/gpu_memcpy: Rip out SKL+
...
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19852 >
2022-12-02 09:18:16 +00:00
Jason Ekstrand
6d80ce1283
hasvk/state: Rip out SKL+
...
v2: Fix incorrectly removed l3cr.SLMEnable setting (Lionel)
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19852 >
2022-12-02 09:18:16 +00:00
Jason Ekstrand
ce57cc4397
hasvk/blorp: Rip out SKL+
...
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19852 >
2022-12-02 09:18:16 +00:00
Jason Ekstrand
cc68b7cd94
hasvk/pipeline: Rip out SKL+
...
v2: Fix incorrect DispatchMode removal (Lionel)
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19852 >
2022-12-02 09:18:16 +00:00
Jason Ekstrand
91090e39af
hasvk/cmd_buffer: Rip out SKL+ support
...
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19852 >
2022-12-02 09:18:16 +00:00
Jason Ekstrand
216e5d6e10
hasvk: Drop anv_nir_add_base_work_group_id()
...
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20068 >
2022-12-01 04:56:48 +00:00
Jason Ekstrand
19ad2629d0
hasvk: Implement lower_base_workgroup_id
...
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20068 >
2022-12-01 04:56:48 +00:00
Yonggang Luo
40a9fc57aa
tree-wide: Use __func__ instead of __FUNCTION__ in non-gallium code
...
Signed-off-by: Yonggang Luo <luoyonggang@gmail.com >
Acked-by: Erik Faye-Lund <erik.faye-lund@collabora.com >
Acked-by: David Heidelberg <david.heidelberg@collabora.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19861 >
2022-11-22 06:53:46 +00:00
Lionel Landwerlin
56bd81ee21
anv/perf: fixup counter/query mapping
...
The intel_perf_counter_pass::pass field is actually useless and
invalid.
Once you have mapped all the counters to all the metrics, the order of
the metrics capture is dictated by intel_perf_get_n_passes().
When reading values that is the order we should follow.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Fixes: 2001a80d4a ("anv: Implement VK_KHR_performance_query")
Reviewed-by: Ivan Briano <ivan.briano@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18893 >
2022-11-17 12:57:06 +00:00
Mark Collins
086b50078d
common/utrace: Rename u_trace_context_actively_tracing to u_trace_should_process
...
Signed-off-by: Mark Collins <mark@igalia.com >
Reviewed-by: Danylo Piliaiev <dpiliaiev@igalia.com >
Reviewed-by: Yonggang Luo <luoyonggang@gmail.com >
Ack-by: Chia-I Wu <olvaffe@gmail.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18271 >
2022-11-11 13:50:56 +00:00
Jason Ekstrand
4d63beaae6
hasvk: Switch to common code for command buffer lifecycles
...
This gets us command buffer object recycling.
Reviewed-by: José Roberto de Souza <jose.souza@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18383 >
2022-11-10 11:15:23 +00:00
José Roberto de Souza
41ee836c9a
intel: Add and use intel_gem_can_render_on_fd()
...
Reviewed-by: Tapani Pälli <tapani.palli@intel.com >
Signed-off-by: José Roberto de Souza <jose.souza@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19425 >
2022-11-07 17:22:14 +00:00
José Roberto de Souza
29550bc50a
intel: Add has_context_isolation to intel_device_info
...
Iris, hasvk and anv were fetching the same information, better do it
on one place.
Reviewed-by: Tapani Pälli <tapani.palli@intel.com >
Signed-off-by: José Roberto de Souza <jose.souza@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19425 >
2022-11-07 17:22:14 +00:00
José Roberto de Souza
d5d1331381
intel: Add has_userptr_probe to intel_device_info
...
Iris, hasvk and anv were fetching the same information, better do it
on one place.
Reviewed-by: Tapani Pälli <tapani.palli@intel.com >
Signed-off-by: José Roberto de Souza <jose.souza@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19425 >
2022-11-07 17:22:14 +00:00
José Roberto de Souza
e9eceb1106
intel: Add has_mmap_offset to intel_device_info
...
All 4 drivers were fetching the same information, better do it on one
place.
Reviewed-by: Tapani Pälli <tapani.palli@intel.com >
Signed-off-by: José Roberto de Souza <jose.souza@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19425 >
2022-11-07 17:22:14 +00:00
José Roberto de Souza
dfd20f002f
intel: Add and use intel_gem_get_param()
...
Again sharing the same function across all Intel drivers.
Reviewed-by: Tapani Pälli <tapani.palli@intel.com >
Signed-off-by: José Roberto de Souza <jose.souza@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19425 >
2022-11-07 17:22:14 +00:00
Mauro Rossi
814b822fe0
hasvk: fix android build and reported API version
...
anv_device.c for vulkan.intel_hasvk requires changes to be compiled
and behave correctly for android target
Fixes the following building error:
FAILED: src/intel/vulkan_hasvk/libanv_hasvk_common.a.p/anv_device.c.o
...
../src/intel/vulkan_hasvk/anv_device.c:143:19: error: use of undeclared identifier 'ANV_API_VERSION_1_3'
*pApiVersion = ANV_API_VERSION_1_3;
^
../src/intel/vulkan_hasvk/anv_device.c:1822:44: error: use of undeclared identifier 'ANV_API_VERSION_1_3'
.apiVersion = pdevice->use_softpin ? ANV_API_VERSION_1_3 : ANV_API_VERSION_1_2,
^
../src/intel/vulkan_hasvk/anv_device.c:1822:66: error: use of undeclared identifier 'ANV_API_VERSION_1_2'
.apiVersion = pdevice->use_softpin ? ANV_API_VERSION_1_3 : ANV_API_VERSION_1_2,
^
3 errors generated.
Cc: "22.3" mesa-stable
Fixes: 00eefdc ("hasvk: stop advertising Vk 1.3 on non-softpin")
Reviewed-by: Tapani Pälli <tapani.palli@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19452 >
2022-11-03 23:33:14 +00:00
José Roberto de Souza
39486661e9
intel: Add and use intel_gem_set_context_param()
...
Again sharing the same function across all Intel drivers.
Signed-off-by: José Roberto de Souza <jose.souza@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18974 >
2022-11-03 21:01:30 +00:00
José Roberto de Souza
6ae6921216
intel: Add and use intel_gem_destroy_context()
...
Again sharing the same function across all Intel drivers.
Signed-off-by: José Roberto de Souza <jose.souza@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18974 >
2022-11-03 21:01:30 +00:00
José Roberto de Souza
f928ead625
intel: Add and use intel_gem_create_context()
...
Add intel_gem_create_context() to common/intel_gem.c/h and use it
on Iris, Crocus, ANV and HASVK.
Signed-off-by: José Roberto de Souza <jose.souza@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18974 >
2022-11-03 21:01:30 +00:00
José Roberto de Souza
ce4a7e7d40
intel: Refactor intel_gem_create_context_engines()
...
This function was returning a int but there was no meaninfull errno
code being returned, also context_id is a uint32_t what would be
problematic if i915 even returned 2147483648(-1).
So here changing the return type and add context_id pointer parameter.
Signed-off-by: José Roberto de Souza <jose.souza@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18974 >
2022-11-03 21:01:30 +00:00
Illia Abernikhin
aa4ac5ff8b
utils: Merge util/debug.* into util/u_debug.* and remove util/debug.*
...
Rename env_var_as_unsigned() -> debug_get_num_option(), because duplicate
Rename env_var_as_bool() -> debug_get_bool_option(), because duplicate
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7177
Signed-off-by: Illia Abernikhin <illia.abernikhin@globallogic.com >
Reviewed-by: Yonggang Luo <luoyonggang@gmail.com >
Reviewed-by: Rob Clark <robdclark@chromium.org >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19336 >
2022-11-02 07:25:39 +00:00
Kenneth Graunke
fde99747e9
nir: Drop infer_non_readable option for nir_opt_access()
...
Everybody sets it to true now, and the only reason for the option to
exist was to work around a bug that's now been fixed.
Reviewed-by: Emma Anholt <emma@anholt.net >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19162 >
2022-11-02 03:42:04 +00:00
Tapani Pälli
7cfd0e8d31
hasvk: remove some unused functions
...
Signed-off-by: Tapani Pälli <tapani.palli@intel.com >
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19368 >
2022-10-31 06:59:36 +00:00
José Roberto de Souza
5bbe3271e6
hasvk: Fix build around intel_measure_state_changed() call
...
Fixes: 2bc82581ad ("anv: add support for mesh shading in INTEL_MEASURE")
Signed-off-by: José Roberto de Souza <jose.souza@intel.com >
Reviewed-by: Marcin Ślusarz <marcin.slusarz@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19355 >
2022-10-27 10:31:30 -07:00
Iago Toral Quiroga
9deef4cde6
vulkan/runtime: include robustness info when hashing a shader stage
...
Suggested by Jason Ekstrand.
Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18883 >
2022-10-27 08:17:11 +00:00
José Roberto de Souza
4096c15f4f
hasvk: Nuke code around local memory
...
None of the platforms supported by this driver supports local memory.
Signed-off-by: José Roberto de Souza <jose.souza@intel.com >
Reviewed-by: Ivan Briano <ivan.briano@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19240 >
2022-10-23 16:33:20 -07:00
Iván Briano
cde0778d3d
hasvk: use DX rules for point rasterization
...
It seems that's what the reference renderer in the CTS expects for
Vulkan. This mostly matters if the edges of a point primitive fall
exactly on a pixel sampling point.
Fixes some upcoming tests under
dEQP-VK.pipeline.monolithic.depth.format.*.point_list*
Reviewed-by: Tapani Pälli <tapani.palli@intel.com >
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19026 >
2022-10-19 00:20:48 +00:00